From: Adam Dinwoodie <adam@dinwoodie•org>
To: Ramsay Jones <ramsay@ramsayjones•plus.com>, git@vger•kernel.org
Cc: "Jonathan Nieder" <jrnieder@gmail•com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Subject: Re: Binary grep t7008 known breakage vanished on Cygwin
Date: Tue, 19 Apr 2016 09:42:32 +0100 [thread overview]
Message-ID: <20160419084232.GE2345@dinwoodie.org> (raw)
In-Reply-To: <5715147F.7020609@ramsayjones.plus.com>
On Mon, Apr 18, 2016 at 06:08:15PM +0100, Ramsay Jones wrote:
> On 18/04/16 16:21, Adam Dinwoodie wrote:
> > t7008.12 is marked as an expected failure, but building Git on Cygwin
> > including a `make configure && ./configure` step has the test
> > unexpectedly passing. Building without the configure step has the test
> > failing as expected.
> >
> > This appears to be behaviour specific to Cygwin; at least I get that
> > test failing on my CentOS box regardless of whether I perform the
> > configure step.
>
> Yes, the configure sets NO_REGEX= whereas the config.mak.uname sets
> NO_REGEX=UnfortunatelyYes.
>
> [Note that the regex bug (see t0070-fundamental.sh test #5) now seems to
> pass with the 'native' regex library]
Ah, that makes sense.
I'm still not quite sure what the "correct" thing to do here is; it
looks as though the NOREGEX=UnfortunatelyYes can disappear from
config.mak.uname, but that still leaves t7008.12 passing when it's
expected to fail.
Adam
next prev parent reply other threads:[~2016-04-19 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 15:21 Binary grep t7008 known breakage vanished on Cygwin Adam Dinwoodie
2016-04-18 17:08 ` Ramsay Jones
2016-04-19 8:42 ` Adam Dinwoodie [this message]
2016-04-19 18:52 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419084232.GE2345@dinwoodie.org \
--to=adam@dinwoodie$(echo .)org \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=ramsay@ramsayjones$(echo .)plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox