public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jonathan Nieder <jrnieder@gmail•com>
To: Jonathan Tan <jonathantanmy@google•com>
Cc: git@vger•kernel.org, spearce@spearce•org, sbeller@google•com,
	peff@peff•net, gitster@pobox•com, Heiko Voigt <hvoigt@hvoigt•net>
Subject: Re: [PATCH] connect: tighten check for unexpected early hang up (Re: [PATCH v3 2/2] connect: advertized capability is not a ref)
Date: Wed, 7 Sep 2016 18:50:40 -0700	[thread overview]
Message-ID: <20160908015040.GF25016@google.com> (raw)
In-Reply-To: <20160908014555.GD25016@google.com>

Jonathan Nieder wrote:

> Subject: connect: tighten check for unexpected early hang up
[...]
> @@ -131,7 +131,7 @@ struct ref **get_remote_heads(int in, char *src_buf, size_t src_len,
>  				  PACKET_READ_GENTLE_ON_EOF |
>  				  PACKET_READ_CHOMP_NEWLINE);
>  		if (len < 0)
> -			die_initial_contact(got_at_least_one_head);
> +			die_initial_contact(first_line);

This should say !first_line.

I'll add tests if the patch seems like a good idea.

Thanks,
Jonathan

next prev parent reply	other threads:[~2016-09-08  1:51 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 17:15 [PATCH 0/2] handle empty spec-compliant remote repos correctly Jonathan Tan
2016-09-02 17:15 ` [PATCH 1/2] tests: move test_lazy_prereq JGIT to test-lib.sh Jonathan Tan
2016-09-02 17:15 ` [PATCH 2/2] connect: know that zero-ID is not a ref Jonathan Tan
2016-09-02 19:37   ` Jonathan Nieder
2016-09-02 19:39   ` Shawn Pearce
2016-09-02 19:56     ` Stefan Beller
2016-09-02 20:00       ` Shawn Pearce
2016-09-02 20:13   ` Jeff King
2016-09-02 22:11     ` Jonathan Tan
2016-09-02 23:19       ` Jeff King
2016-09-03  2:03     ` Shawn Pearce
2016-09-03  2:17       ` Jeff King
2016-09-02 22:06 ` [PATCH v2 0/2] handle empty spec-compliant remote repos correctly Jonathan Tan
2016-09-02 22:06   ` [PATCH v2 1/2] tests: move test_lazy_prereq JGIT to test-lib.sh Jonathan Tan
2016-09-07 16:47     ` Junio C Hamano
2016-09-02 22:06   ` [PATCH v2 2/2] connect: advertized capability is not a ref Jonathan Tan
2016-09-02 22:40     ` Jonathan Nieder
2016-09-02 23:35     ` Jeff King
2016-09-02 23:48       ` Stefan Beller
2016-09-03  0:37         ` Jonathan Nieder
2016-09-02 23:51       ` Jonathan Nieder
2016-09-03  0:56         ` Jeff King
2016-09-07 17:02     ` Junio C Hamano
2016-09-07 17:10     ` Junio C Hamano
2016-09-07 20:38       ` Jonathan Nieder
2016-09-07 23:02         ` Junio C Hamano
2016-09-07 23:50 ` [PATCH v3 0/2] handle empty spec-compliant remote repos correctly Jonathan Tan
2016-09-07 23:50   ` [PATCH v3 1/2] tests: move test_lazy_prereq JGIT to test-lib.sh Jonathan Tan
2016-09-07 23:50   ` [PATCH v3 2/2] connect: advertized capability is not a ref Jonathan Tan
2016-09-08  1:34     ` Jonathan Nieder
2016-09-08  1:45       ` [PATCH] connect: tighten check for unexpected early hang up (Re: [PATCH v3 2/2] connect: advertized capability is not a ref) Jonathan Nieder
2016-09-08  1:46         ` Jonathan Nieder
2016-09-08  1:50         ` Jonathan Nieder [this message]
2016-09-08 16:42           ` Junio C Hamano
2016-09-08 16:28         ` Stefan Beller
2016-09-08 16:18       ` [PATCH v3 2/2] connect: advertized capability is not a ref Junio C Hamano
2016-09-09 17:36 ` [PATCH v4 0/3] handle empty spec-compliant remote repos correctly Jonathan Tan
2016-09-09 17:36   ` [PATCH v4 1/3] tests: move test_lazy_prereq JGIT to test-lib.sh Jonathan Tan
2016-09-10  5:51     ` Torsten Bögershausen
2016-09-10  6:00       ` Jeff King
2016-09-09 17:36   ` [PATCH v4 2/3] connect: tighten check for unexpected early hang up Jonathan Tan
2016-09-09 17:36   ` [PATCH v4 3/3] connect: advertized capability is not a ref Jonathan Tan
2016-09-09 19:40     ` Jonathan Nieder
2016-09-09 20:40       ` Junio C Hamano
2016-09-09 20:09     ` Junio C Hamano
2016-09-09 20:17 ` [PATCH v5 0/3] handle empty spec-compliant remote repos correctly Jonathan Tan
2016-09-09 20:17   ` [PATCH v5 1/3] tests: move test_lazy_prereq JGIT to test-lib.sh Jonathan Tan
2016-09-09 20:17   ` [PATCH v5 2/3] connect: tighten check for unexpected early hang up Jonathan Tan
2016-09-09 20:17   ` [PATCH v5 3/3] connect: advertized capability is not a ref Jonathan Tan
2016-09-09 21:07   ` [PATCH v5 0/3] handle empty spec-compliant remote repos correctly Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160908015040.GF25016@google.com \
    --to=jrnieder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=hvoigt@hvoigt$(echo .)net \
    --cc=jonathantanmy@google$(echo .)com \
    --cc=peff@peff$(echo .)net \
    --cc=sbeller@google$(echo .)com \
    --cc=spearce@spearce$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox