Subject: Re: [PATCH 31/35] pathspec: allow querying for attributes

From: Brandon Williams <[email-masked]>
Date: Mon, 28 Nov 2016 10:02:23 -0800

On 11/10, Stefan Beller wrote:
> @@ -500,6 +586,18 @@ void copy_pathspec(struct pathspec *dst, const struct pathspec *src)
>  
>  void clear_pathspec(struct pathspec *pathspec)
>  {
> +	int i, j;
> +	for (i = 0; i < pathspec->nr; i++) {
> +		if (!pathspec->items[i].attr_match_nr)
> +			continue;
> +		for (j = 0; j < pathspec->items[j].attr_match_nr; j++)

This looks like a bug.  Should it be:
  for (j = 0; j < pathspec->items[i].attr_match_nr; j++)

where items[j] -> items[i]

-- 
Brandon Williams