Subject: Re: [PATCH v4 00/16] pathspec cleanup

From: Brandon Williams <[email-masked]>
Date: Wed, 4 Jan 2017 09:56:08 -0800

On 01/04, Brandon Williams wrote:
> On 01/04, Duy Nguyen wrote:
> > On Wed, Jan 4, 2017 at 1:42 AM, Brandon Williams <[email-masked]> wrote:
> > > diff --git a/dir.c b/dir.c
> > > index 15f7c9993..e8ddd7f8a 100644
> > > --- a/dir.c
> > > +++ b/dir.c
> > > @@ -1353,6 +1353,15 @@ static int simplify_away(const char *path, int pathlen,
> > >  {
> > >         int i;
> > >
> > > +       if (pathspec)
> > > +               guard_pathspec(pathspec,
> > > +                              pathspec_fromtop |
> > > +                              pathspec_maxdepth |
> > > +                              pathspec_literal |
> > > +                              pathspec_glob |
> > > +                              pathspec_icase |
> > > +                              pathspec_exclude);
> > 
> > You have done some magic (or your MTA/editor did) to lower case
> > GUARD_PATHSPEC and all the flags. The real patch looks good though, so
> > no problem.
> 
> That's really odd, I was sure I just did a cut and paste.  I'll fix that
> :)

So it looks like what ever I did to insert this into the cover letter
made everything lower case.  The actual patch itself looks fine.

-- 
Brandon Williams