Subject: Re: [PATCH 03/18] lib-submodule-update: teach test_submodule_content the -C <dir> flag

From: Eric Wong <[email-masked]>
Date: Thu, 2 Mar 2017 02:11:35 +0000

Stefan Beller <[email-masked]> wrote:
>  test_submodule_content () {
> +	if test "$1" == "-C"

Use a single '=' for portability in sh.  It's also a good idea
to prefix variables with 'x' or some such, since "$1" could be
"-n" or some other supported switch for test(1).
So, something like:

	if test x"$1" = "x-C"

...or use a case statement.

On Debian systems, I use the "checkbashisms" from the
"devscripts" package to find and avoid bash dependencies.

Thanks.