Subject: Re: [PATCH v2 07/11] submodule update: add `--init-active` switch

From: Brandon Williams <[email-masked]>
Date: Thu, 9 Mar 2017 10:08:12 -0800

On 03/08, Stefan Beller wrote:
> On Wed, Mar 8, 2017 at 5:23 PM, Brandon Williams <[email-masked]> wrote:
> > The new switch `--init-active` initializes the submodules which are
> > configured in `submodule.active` instead of those given as
> > command line arguments before updating. In the first implementation this
> > is made incompatible with further command line arguments as it is
> > unclear what the user means by
> >
> >     git submodule update --init --init-active <paths>
> >
> > This new switch allows users to record more complex patterns as it saves
> > retyping them whenever you invoke update.
> >
> > Based on a patch by Stefan Beller <[email-masked]>
> >
> > Signed-off-by: Brandon Williams <[email-masked]>
> 
> 
> 
> > @@ -568,7 +573,17 @@ cmd_update()
> >
> >         if test -n "$init"
> >         then
> > -               cmd_init "--" "$@" || return
> > +               if test "$init" = "by_config"
> > +               then
> > +                       if test $# -gt 0
> > +                       then
> > +                               die "$(gettext "path arguments are incompatible with --init-active")"
> > +                       fi
> > +                       cmd_init "--" $(git config --get-all submodule.active) || return
> 
> What happens with submodule.<name>.actives here?

Nothing?  I am still not 100% certain that we really need the
submodule.<name>.active config but it seemed like what we decided upon
last we discussed this.

Maybe we don't even need this as an option?  Maybe update should be able
to just 'update' all active submodules without having to make an
explicit call to cmd_init?

-- 
Brandon Williams