Subject: Re: [PATCH v2 1/2] push: unmark a local variable as static

From: Brandon Williams <[email-masked]>
Date: Fri, 31 Mar 2017 17:16:55 -0700

On 03/31, Jonathan Nieder wrote:
> Brandon Williams wrote:
> 
> >                         Also, clear the push_options string_list to
> > prevent memory leaking.
> 
> That's not a real leak, right?  Is the motivation to make it not show up
> in valgrind output?

well depends on what you classify as a leak.  I guess since the program
will exit soon its not an issue, but there is still memory that was
alloc'd that wasn't freed before the variable pointing to it went out of
scope. :D
> 
> At first it didn't look related to the other change but then the
> connection dawned on me.
> 
> > Signed-off-by: Brandon Williams <[email-masked]>
> > ---
> >  builtin/push.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> For what it's worth,
> Reviewed-by: Jonathan Nieder <[email-masked]>

-- 
Brandon Williams