From: Brandon Williams <bmwill@google•com>
To: Jacob Keller <jacob.e.keller@intel•com>
Cc: git@vger•kernel.org, Stefan Beller <sbeller@google•com>,
Jacob Keller <jacob.keller@gmail•com>
Subject: Re: [PATCH v2 2/2] ls-files: fix path used when recursing into submodules
Date: Thu, 13 Apr 2017 11:10:31 -0700 [thread overview]
Message-ID: <20170413181031.GB96917@google.com> (raw)
In-Reply-To: <20170413171224.3537-2-jacob.e.keller@intel.com>
On 04/13, Jacob Keller wrote:
> From: Jacob Keller <jacob.keller@gmail•com>
>
> Don't assume that the current working directory is the root of the
> repository. Correctly generate the path for the recursing child
> processes by building it from the work_tree() root instead. Otherwise if
> we run ls-files using --git-dir or --work-tree it will not work
> correctly as it attempts to change directory into a potentially invalid
> location. Best case, it doesn't exist and we produce an error. Worst
> case we cd into the wrong location and unknown behavior occurs.
>
> Add a new test which highlights this possibility.
>
> Signed-off-by: Jacob Keller <jacob.keller@gmail•com>
> ---
> I'm not sure that I'm convinced by this method of solving the problem as
> I suspect it has some corner cases (what about when run inside a
> subdirectory? It seems to work for me but I'm not sure...) Additionally,
> it felt weird that there's no helper function for creating a toplevel
> relative path.
I never considered the case where you use --git-dir or --work-tree,
definitely an oversight on my part. This change seems reasonable to me.
--
Brandon Williams
next prev parent reply other threads:[~2017-04-13 18:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 0:39 [PATCH] ls-files: properly prepare submodule environment Jacob Keller
2017-04-12 16:58 ` Brandon Williams
2017-04-12 22:45 ` Jacob Keller
2017-04-13 17:12 ` [PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules Jacob Keller
2017-04-13 17:12 ` [PATCH v2 2/2] ls-files: fix path used when recursing into submodules Jacob Keller
2017-04-13 18:10 ` Brandon Williams [this message]
2017-04-13 18:15 ` Stefan Beller
2017-04-13 18:34 ` Jacob Keller
2017-04-18 2:03 ` Junio C Hamano
2017-04-18 7:42 ` Jacob Keller
2017-04-18 18:41 ` Stefan Beller
2017-04-13 18:03 ` [PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules Brandon Williams
2017-04-13 18:31 ` Jacob Keller
2017-04-13 18:35 ` Stefan Beller
2017-04-13 18:36 ` Brandon Williams
2017-04-13 18:57 ` [PATCH 3/2] ls-files: only recurse on active submodules Brandon Williams
2017-04-13 19:05 ` Stefan Beller
2017-04-13 19:12 ` Jacob Keller
2017-04-13 19:25 ` Stefan Beller
2017-04-13 19:30 ` Jacob Keller
2017-04-14 16:33 ` Jacob Keller
2017-04-14 17:02 ` Stefan Beller
2017-04-14 23:49 ` Jacob Keller
2017-04-19 1:03 ` Junio C Hamano
2017-05-12 16:21 ` paul
2017-05-12 17:26 ` Brandon Williams
2017-05-12 18:12 ` Paul Jolly
2017-05-12 18:19 ` Brandon Williams
2017-08-01 18:16 ` Paul Jolly
[not found] ` <CACoUkn7i76dEsQa3eoN+7WR8QmsD1pWsRQ0dvhkxzFN0sxTmRQ@mail.gmail.com>
2017-08-01 18:18 ` Brandon Williams
2017-08-01 18:19 ` Paul Jolly
2017-08-01 18:20 ` Brandon Williams
2017-08-01 18:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413181031.GB96917@google.com \
--to=bmwill@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jacob.keller@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox