From: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
To: git@vger•kernel.org
Cc: "Junio C Hamano" <gitster@pobox•com>,
"Brandon Williams" <bmwill@google•com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>,
"Jonathan Nieder" <jrnieder@gmail•com>,
"Stefan Beller" <sbeller@google•com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Subject: [PATCH v3 0/5] clone: --no-tags option
Date: Wed, 26 Apr 2017 23:12:31 +0000 [thread overview]
Message-ID: <20170426231236.27219-1-avarab@gmail.com> (raw)
This is an expansion of the previously solo 02/05 "clone: add a
--no-tags option to clone without tags" patch (see
<20170418191553.15464-1-avarab@gmail•com>).
This addresses the comments by Junio & Jonathan Nieder on v2 (thanks a
lot), and in addition implements a --no-tags-submodules option. That
code was implemented by Brandon & sent to me privately after I'd
failed to come up with it, but I added tests, a commit message & bash
completion to it.
The WIP 5/5 patch implements a submodule.NAME.tags config facility for
the option, but is broken currently & floats along in this submission
as an RFC patch. AFAICT it *should* work and it goes through all the
motions the similar existing *.shallow config does, but for some
reason the tags=false option isn't picked up & propagated in a freshly
cloned submodule.
I'm probably missing something trivial, but I can't see what it is,
I'm hoping thath either Stefan or Brandon will see what that is.
Brandon Williams (1):
clone: add a --no-tags-submodules to pass --no-tags to submodules
Ævar Arnfjörð Bjarmason (4):
tests: change "cd ... && git fetch" to "cd &&\n\tgit fetch"
clone: add a --no-tags option to clone without tags
tests: rename a test having to do with shallow submodules
WIP clone: add a --[no-]recommend-tags & submodule.NAME.tags config
Documentation/git-clone.txt | 21 ++++
Documentation/git-submodule.txt | 8 +-
builtin/clone.c | 19 +++-
builtin/submodule--helper.c | 21 +++-
contrib/completion/git-completion.bash | 3 +
git-submodule.sh | 13 ++-
submodule-config.c | 8 ++
submodule-config.h | 1 +
t/t5612-clone-refspec.sh | 103 +++++++++++++++++---
...odules.sh => t5614-clone-submodules-shallow.sh} | 0
t/t5616-clone-submodules-tags.sh | 106 +++++++++++++++++++++
11 files changed, 284 insertions(+), 19 deletions(-)
rename t/{t5614-clone-submodules.sh => t5614-clone-submodules-shallow.sh} (100%)
create mode 100755 t/t5616-clone-submodules-tags.sh
--
2.11.0
next reply other threads:[~2017-04-26 23:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 23:12 Ævar Arnfjörð Bjarmason [this message]
2017-04-26 23:12 ` [PATCH v3 1/5] tests: change "cd ... && git fetch" to "cd &&\n\tgit fetch" Ævar Arnfjörð Bjarmason
2017-04-26 23:12 ` [PATCH v3 2/5] clone: add a --no-tags option to clone without tags Ævar Arnfjörð Bjarmason
2017-04-27 17:54 ` Stefan Beller
2017-04-27 22:12 ` Brandon Williams
2017-04-28 14:44 ` Ævar Arnfjörð Bjarmason
2017-04-26 23:12 ` [PATCH v3 3/5] tests: rename a test having to do with shallow submodules Ævar Arnfjörð Bjarmason
2017-04-27 17:58 ` Stefan Beller
2017-04-27 22:13 ` Brandon Williams
2017-04-28 8:59 ` Ævar Arnfjörð Bjarmason
2017-04-28 17:50 ` Stefan Beller
2017-04-26 23:12 ` [PATCH v3 4/5] clone: add a --no-tags-submodules to pass --no-tags to submodules Ævar Arnfjörð Bjarmason
2017-04-27 2:34 ` Junio C Hamano
2017-04-27 16:33 ` Brandon Williams
2017-04-27 18:27 ` Stefan Beller
2017-04-27 22:19 ` Brandon Williams
2017-04-26 23:12 ` [RFC/PATCH v3 5/5] WIP clone: add a --[no-]recommend-tags & submodule.NAME.tags config Ævar Arnfjörð Bjarmason
2017-04-27 19:36 ` Stefan Beller
2017-04-27 22:27 ` [PATCH v3 0/5] clone: --no-tags option Brandon Williams
2017-04-28 8:57 ` Ævar Arnfjörð Bjarmason
2017-04-28 19:11 ` Ævar Arnfjörð Bjarmason
2017-04-28 19:16 ` Stefan Beller
2017-05-01 1:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426231236.27219-1-avarab@gmail.com \
--to=avarab@gmail$(echo .)com \
--cc=bmwill@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox