From: Brandon Williams <bmwill@google•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org, gitster@pobox•com, jrnieder@gmail•com
Subject: Re: [PATCH 0/4] config.h
Date: Mon, 12 Jun 2017 14:53:52 -0700 [thread overview]
Message-ID: <20170612215352.GE154599@google.com> (raw)
In-Reply-To: <20170612214502.xynyfswj2ipf25ah@sigill.intra.peff.net>
On 06/12, Jeff King wrote:
> On Mon, Jun 12, 2017 at 02:34:02PM -0700, Brandon Williams wrote:
>
> > After some discussion I realized that my 'repository object' series was getting
> > to be rather long and increase in scope. So I've decided to break off these
> > couple patches into their own series so they can be reviewed more easily. This
> > should also let them be merged in faster as I suspect it'll take a while for my
> > 'repository object' series to be reviewed thourouly and these couple patches
> > could result in a lot of merge conflicts as it touches a lot of files.
> >
> > Brandon Williams (4):
> > config: create config.h
> > config: remove git_config_iter
> > config: don't include config.h by default
> > config: don't implicitly use gitdir
>
> These all seem reasonable to me. Patch 3 made me shrug a little, because
> it seems like the majority of C files end up including it anyway. I
> suspect you could break config.h down into two files: the few things
> that everybody needs (git_config() and the few parsing functions needed
> in callbacks) and the ones for commands that actually manipulate the
> config.
>
> That would reduce the surface area of the module that most callers look
> at, but I don't think there's a huge benefit to doing so (mostly it just
> makes re-compiling faster by decreasing the chance that a dependent
> header has changed for each file).
Yes, ultimately I think it would be a good thing to break config.c down
into at least 2 more files (the file parsing logic and the config_set
logic) but that can be done at a later point. I started looking at
doing that now but that logic is a little more entangled than I thought
it was.
Thanks for taking a look Jeff!
--
Brandon Williams
next prev parent reply other threads:[~2017-06-12 21:53 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 21:34 [PATCH 0/4] config.h Brandon Williams
2017-06-12 21:34 ` [PATCH 1/4] config: create config.h Brandon Williams
2017-06-12 21:34 ` [PATCH 2/4] config: remove git_config_iter Brandon Williams
2017-06-13 0:49 ` Jonathan Nieder
2017-06-13 0:57 ` Jeff King
2017-06-12 21:34 ` [PATCH 3/4] config: don't include config.h by default Brandon Williams
2017-06-12 21:34 ` [PATCH 4/4] config: don't implicitly use gitdir Brandon Williams
2017-06-13 1:05 ` Jonathan Nieder
2017-06-13 1:23 ` Brandon Williams
2017-06-13 1:33 ` Jonathan Nieder
2017-06-13 1:38 ` Jonathan Nieder
2017-06-13 2:59 ` Jeff King
2017-06-13 6:16 ` Brandon Williams
2017-06-13 6:45 ` Jeff King
2017-06-13 7:08 ` Jeff King
2017-06-13 14:43 ` Brandon Williams
2017-06-13 17:06 ` Jonathan Nieder
2017-06-13 5:52 ` Brandon Williams
2017-06-13 6:29 ` Jeff King
2017-06-13 14:47 ` Brandon Williams
2017-06-12 21:45 ` [PATCH 0/4] config.h Jeff King
2017-06-12 21:53 ` Brandon Williams [this message]
2017-06-12 22:02 ` Jeff King
2017-06-12 22:06 ` Brandon Williams
2017-06-13 1:07 ` Jonathan Nieder
2017-06-13 21:03 ` [PATCH v2 0/6] config.h Brandon Williams
2017-06-13 21:03 ` [PATCH v2 1/6] config: create config.h Brandon Williams
2017-06-13 21:13 ` Jonathan Nieder
2017-06-13 21:03 ` [PATCH v2 2/6] config: remove git_config_iter Brandon Williams
2017-06-13 21:14 ` Jonathan Nieder
2017-06-13 21:03 ` [PATCH v2 3/6] config: don't include config.h by default Brandon Williams
2017-06-13 21:58 ` Jonathan Nieder
2017-06-13 21:03 ` [PATCH v2 4/6] config: don't implicitly use gitdir Brandon Williams
2017-06-13 21:08 ` Jonathan Nieder
2017-06-13 21:38 ` Brandon Williams
2017-06-13 21:51 ` Jonathan Nieder
2017-06-13 21:55 ` Junio C Hamano
2017-06-13 22:05 ` Jonathan Nieder
2017-06-14 4:40 ` Jacob Keller
2017-06-14 6:25 ` Jeff King
2017-06-14 17:14 ` Brandon Williams
2017-06-13 21:03 ` [PATCH v2 5/6] setup: teach discover_git_directory to respect the commondir Brandon Williams
2017-06-14 6:15 ` Jeff King
2017-06-14 17:19 ` Brandon Williams
2017-06-13 21:03 ` [PATCH v2 6/6] config: respect commondir Brandon Williams
2017-06-14 18:07 ` [PATCH v3 0/6] config.h Brandon Williams
2017-06-14 18:07 ` [PATCH v3 1/6] config: create config.h Brandon Williams
2017-06-14 18:07 ` [PATCH v3 2/6] config: remove git_config_iter Brandon Williams
2017-06-14 18:07 ` [PATCH v3 3/6] config: don't include config.h by default Brandon Williams
2017-06-14 18:07 ` [PATCH v3 4/6] setup: teach discover_git_directory to respect the commondir Brandon Williams
2017-06-14 18:07 ` [PATCH v3 5/6] config: respect commondir Brandon Williams
2017-06-14 18:07 ` [PATCH v3 6/6] config: don't implicitly use gitdir or commondir Brandon Williams
2017-06-15 19:59 ` [PATCH v3 0/6] config.h Junio C Hamano
2017-06-15 20:33 ` Brandon Williams
2017-06-15 21:09 ` Junio C Hamano
2017-06-15 21:18 ` Brandon Williams
2017-06-16 0:12 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612215352.GE154599@google.com \
--to=bmwill@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox