From: Charles Bailey <charles@hashpling•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: Victor Toni <victor.toni@gmail•com>,
git@vger•kernel.org, Charles Bailey <cbailey32@bloomberg•net>,
Jeff King <peff@peff•net>
Subject: Re: Handling of paths
Date: Thu, 20 Jul 2017 21:05:23 +0100 [thread overview]
Message-ID: <20170720200523.GA13792@hashpling.org> (raw)
In-Reply-To: <xmqq7ez2lwsv.fsf@gitster.mtv.corp.google.com>
On Thu, Jul 20, 2017 at 12:42:40PM -0700, Junio C Hamano wrote:
> Victor Toni <victor.toni@gmail•com> writes:
>
> > What's unexpected is that paths used for sslKey or sslCert are treated
> > differently insofar as they are expected to be absolute.
> > Relative paths (whether with or without "~") don't work.
>
> It appears that only two of these among four were made aware of the
> "~[username]/" prefix in bf9acba2 ("http: treat config options
> sslCAPath and sslCAInfo as paths", 2015-11-23), but "sslkey" and
> "sslcert" were still left as plain vanilla strings. I do not know
> if that was an elaborate omission, or a mere oversight, as it seems
> that it happened while I was away, so...
It was more of an oversight than a deliberate omission, but more
accurately I didn't actively consider whether the other http.ssl*
variables were pathname-like or not.
At the time I was trying to make a config which needed to set
http.sslCAPath and/or http.sslCAInfo more portable between users and
these were "obviously" pathname-like to me. Now that I read
the help for http.sslCert and http.sslKey, I see no reason that they
shouldn't also use git_config_pathname. If I'd been more thorough I
would have proposed this at the time.
Charles.
next prev parent reply other threads:[~2017-07-20 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 16:48 Handling of paths Victor Toni
2017-07-20 19:42 ` Junio C Hamano
2017-07-20 20:05 ` Charles Bailey [this message]
2017-07-20 20:30 ` Junio C Hamano
2017-07-20 20:52 ` Charles Bailey
2017-07-20 21:03 ` Victor Toni
2017-07-21 15:15 ` Junio C Hamano
2017-07-24 16:52 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720200523.GA13792@hashpling.org \
--to=charles@hashpling$(echo .)org \
--cc=cbailey32@bloomberg$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=victor.toni@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox