From: Keith Smiley <k@keith•so>
To: Kevin Daudt <me@ikke•info>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Add shell completion for git remote rm
Date: Thu, 28 Dec 2017 22:21:03 -0800 [thread overview]
Message-ID: <20171229062103.GA19203@bryant.local> (raw)
In-Reply-To: <20171229060016.GA25718@alpha.vpn.ikke.info>
Sorry about that! Patch below.
Previously git remote rm did not complete your list of removes as remove
does.
Signed-off-by: Keith Smiley <k@keith•so>
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3683c772c5586..3e9044087e6ba 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2665,7 +2665,7 @@ _git_config ()
_git_remote ()
{
local subcommands="
- add rename remove set-head set-branches
+ add rename remove rm set-head set-branches
get-url set-url show prune update
"
local subcommand="$(__git_find_on_cmdline "$subcommands")"
--
Keith Smiley
On 12/29, Kevin Daudt wrote:
>On Fri, Dec 29, 2017 at 02:01:00AM +0000, Keith Smiley wrote:
>> From: Keith Smiley <keithbsmiley@gmail•com>
>>
>> Previously git remote rm did not complete your list of removes as remove
>> does.
>
>Your signed-off-by[1] is missing, could you please add that?
>
>[1]:
>https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L278
>
>> ---
>> contrib/completion/git-completion.bash | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 3683c772c5586..3e9044087e6ba 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -2665,7 +2665,7 @@ _git_config ()
>> _git_remote ()
>> {
>> local subcommands="
>> - add rename remove set-head set-branches
>> + add rename remove rm set-head set-branches
>> get-url set-url show prune update
>> "
>> local subcommand="$(__git_find_on_cmdline "$subcommands")"
>>
>> --
>> https://github.com/git/git/pull/448
prev parent reply other threads:[~2017-12-29 6:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 2:01 [PATCH] Add shell completion for git remote rm Keith Smiley
2017-12-29 3:29 ` Todd Zullinger
2017-12-29 4:19 ` Keith Smiley
2017-12-29 13:52 ` Todd Zullinger
2017-12-29 16:49 ` [PATCH] completion: restore 'remote rm' Keith Smiley
2017-12-29 22:48 ` [PATCH] Add shell completion for git remote rm SZEDER Gábor
2017-12-29 23:19 ` Keith Smiley
2017-12-29 23:20 ` Ævar Arnfjörð Bjarmason
2017-12-30 0:52 ` Todd Zullinger
2017-12-30 12:19 ` Ævar Arnfjörð Bjarmason
2017-12-31 20:44 ` Keith Smiley
2018-01-03 19:24 ` Junio C Hamano
2018-01-15 21:43 ` Keith Smiley
2018-01-16 10:02 ` Duy Nguyen
2018-01-16 18:57 ` Junio C Hamano
2018-01-17 0:44 ` Duy Nguyen
2018-01-17 6:17 ` Kevin Daudt
2018-01-17 9:48 ` Duy Nguyen
2018-07-16 13:12 ` Keith Smiley
2018-01-17 18:20 ` Junio C Hamano
2018-01-01 23:46 ` Duy Nguyen
2017-12-29 6:00 ` Kevin Daudt
2017-12-29 6:21 ` Keith Smiley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229062103.GA19203@bryant.local \
--to=k@keith$(echo .)so \
--cc=git@vger$(echo .)kernel.org \
--cc=me@ikke$(echo .)info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox