Subject: Re: [PATCH 09/26] transport: store protocol version

From: Jonathan Tan <[email-masked]>
Date: Tue, 9 Jan 2018 10:41:25 -0800

On Tue,  2 Jan 2018 16:18:11 -0800
Brandon Williams <[email-masked]> wrote:

> diff --git a/transport.c b/transport.c
> index 63c3dbab9..2378dcb38 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -118,6 +118,7 @@ struct git_transport_data {
>  	struct child_process *conn;
>  	int fd[2];
>  	unsigned got_remote_heads : 1;
> +	enum protocol_version version;

Should this be initialized to protocol_unknown_version? Right now, as
far as I can tell, it is zero-initialized, which means protocol_v0.