Subject: Re: [PATCH v2 05/14] commit-graph: implement git-commit-graph --write

From: SZEDER Gábor <[email-masked]>
Date: Fri, 2 Feb 2018 02:47:28 +0100

> diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
> new file mode 100755
> index 0000000000..6bcd1cc264
> --- /dev/null
> +++ b/t/t5318-commit-graph.sh
> @@ -0,0 +1,96 @@
> +#!/bin/sh
> +
> +test_description='commit graph'
> +. ./test-lib.sh
> +
> +test_expect_success 'setup full repo' \
> +    'rm -rf .git &&
> +     mkdir full &&
> +     cd full &&
> +     git init &&
> +     git config core.commitgraph true &&

This config variable is unknown at this point.
I think the test shouldn't set it before it's introduced in patch 10.

> +     git config pack.threads 1 &&
> +     packdir=".git/objects/pack"'

> +test_expect_success 'setup bare repo' \
> +    'cd .. &&
> +     git clone --bare full bare &&
> +     cd bare &&
> +     git config core.graph true &&

Likewise, and its name should be updated as well.

> +     git config pack.threads 1 &&
> +     baredir="objects/pack"'