Subject: Re: [PATCH v3 23/35] fetch-pack: support shallow requests

From: Jonathan Tan <[email-masked]>
Date: Fri, 23 Feb 2018 11:37:22 -0800

On Tue,  6 Feb 2018 17:13:00 -0800
Brandon Williams <[email-masked]> wrote:

> @@ -1090,6 +1110,10 @@ static int send_fetch_request(int fd_out, const struct fetch_pack_args *args,
>  	if (prefer_ofs_delta)
>  		packet_buf_write(&req_buf, "ofs-delta");
>  
> +	/* Add shallow-info and deepen request */
> +	if (server_supports_feature("fetch", "shallow", 1))
> +		add_shallow_requests(&req_buf, args);

One more thing I observed when trying to implement the server side in
JGit - the last argument should be 0, not 1, right? I don't think that
"shallow" should be required on the server unless we really need it.