public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Eric Wong <e@80x24•org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
	Joseph Mingrone <jrm@ftfl•ca>,
	garga@FreeBSD•org,
	Johannes Schindelin <Johannes.Schindelin@gmx•de>,
	Ben Caradoc-Davies <ben@transient•nz>,
	894997@bugs•debian.org
Subject: Re: [PATCH] git-svn: avoid warning on undef readline()
Date: Fri, 6 Apr 2018 16:56:18 +0000	[thread overview]
Message-ID: <20180406165618.GA6367@80x24.org> (raw)
In-Reply-To: <20180406131514.740-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail•com> wrote:
> See https://public-inbox.org/git/86h8oobl36.fsf@phe.ftfl.ca/ for the
> original report.

Thanks for taking a look at this.  Also https://bugs.debian.org/894997

> --- a/perl/Git.pm
> +++ b/perl/Git.pm
> @@ -554,7 +554,7 @@ sub get_record {
>  	my ($fh, $rs) = @_;
>  	local $/ = $rs;
>  	my $rec = <$fh>;
> -	chomp $rec if defined $rs;
> +	chomp $rec if defined $rs and defined $rec;

I'm struggling to understand the reason for the "defined $rs"
check.  I think it was a braino on my part and meant to use:

	chomp $rec if defined $rec;

next prev parent reply	other threads:[~2018-04-06 16:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 12:01 git 2.17.0: uninitialized value $rec in scalar chomp at ...Git.pm line 557 Joseph Mingrone
2018-04-06 12:21 ` Johannes Schindelin
2018-04-06 12:32   ` Joseph Mingrone
2018-04-06 13:15 ` [PATCH] git-svn: avoid warning on undef readline() Ævar Arnfjörð Bjarmason
2018-04-06 14:30   ` Johannes Schindelin
2018-04-06 16:56   ` Eric Wong [this message]
2018-04-06 18:23     ` Ævar Arnfjörð Bjarmason
2018-04-06 20:49       ` Eric Wong
2018-04-06 21:05         ` Ævar Arnfjörð Bjarmason
2018-04-09  2:09     ` Junio C Hamano
2018-04-07 19:20   ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180406165618.GA6367@80x24.org \
    --to=e@80x24$(echo .)org \
    --cc=894997@bugs$(echo .)debian.org \
    --cc=Johannes.Schindelin@gmx$(echo .)de \
    --cc=avarab@gmail$(echo .)com \
    --cc=ben@transient$(echo .)nz \
    --cc=garga@FreeBSD$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=jrm@ftfl$(echo .)ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox