Subject: Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

From: SZEDER Gábor <[email-masked]>
Date: Thu, 12 Jul 2018 14:37:29 +0200

> Signed-off-by: Eric Sunshine <[email-masked]>
> ---
>  t/t5300-pack-object.sh         |  2 +-
>  t/t5302-pack-index.sh          |  2 +-
>  t/t5401-update-hooks.sh        |  4 ++--
>  t/t5500-fetch-pack.sh          |  2 +-
>  t/t5505-remote.sh              |  2 +-
>  t/t5512-ls-remote.sh           |  4 ++--
>  t/t5516-fetch-push.sh          | 10 +++++-----
>  t/t5517-push-mirror.sh         | 10 +++++-----
>  t/t5526-fetch-submodules.sh    |  2 +-
>  t/t5531-deep-submodule-push.sh |  2 +-
>  t/t5543-atomic-push.sh         |  2 +-
>  t/t5601-clone.sh               |  2 +-
>  t/t5605-clone-local.sh         |  2 +-
>  t/t5801-remote-helpers.sh      |  2 +-
>  14 files changed, 24 insertions(+), 24 deletions(-)

The change below should be squashed into this patch to fix a
previously unnoticed broken &&-chain.  I think you missed it, because
this test script is rather expensive and you didn't run it with
GIT_TEST_CLONE_2GB=YesPlease.

diff --git a/t/t5608-clone-2gb.sh b/t/t5608-clone-2gb.sh
index df822d9a3e..2c6bc07344 100755
--- a/t/t5608-clone-2gb.sh
+++ b/t/t5608-clone-2gb.sh
@@ -23,7 +23,7 @@ test_expect_success CLONE_2GB 'setup' '
 		printf "blob\nmark :$i\ndata $blobsize\n" &&
 		#test-tool genrandom $i $blobsize &&
 		printf "%-${blobsize}s" $i &&
-		echo "M 100644 :$i $i" >> commit
+		echo "M 100644 :$i $i" >> commit &&
 		i=$(($i+1)) ||
 		echo $? > exit-status
 	 done &&