public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Carlo Marcelo Arenas Belón" <carenas@gmail•com>
To: git@vger•kernel.org
Cc: pclouds@gmail•com, "Carlo Marcelo Arenas Belón" <carenas@gmail•com>
Subject: [PATCH] read-cache: use of memory after it is freed
Date: Sat, 20 Oct 2018 00:33:34 -0700	[thread overview]
Message-ID: <20181020073334.48348-1-carenas@gmail.com> (raw)

introduced with c46c406ae1e (trace.h: support nested performance tracing)
on Aug 18, 2018 but not affecting maint

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail•com>
---
 read-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/read-cache.c b/read-cache.c
index 1df5c16dbc..78f47d2f50 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -2297,8 +2297,8 @@ int read_index_from(struct index_state *istate, const char *path,
 	freshen_shared_index(base_path, 0);
 	merge_base_index(istate);
 	post_read_index_from(istate);
-	free(base_path);
 	trace_performance_leave("read cache %s", base_path);
+	free(base_path);
 	return ret;
 }
 
-- 
2.19.1


             reply	other threads:[~2018-10-20  7:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-20  7:33 Carlo Marcelo Arenas Belón [this message]
2018-10-20 15:15 ` [PATCH] read-cache: use of memory after it is freed Duy Nguyen
2018-10-22  3:39   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181020073334.48348-1-carenas@gmail.com \
    --to=carenas@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pclouds@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox