Subject: Re: [PATCH] remote-curl: die on server-side errors

From: Josh Steadmon <[email-masked]>
Date: Tue, 13 Nov 2018 14:28:41 -0800

On 2018.11.13 23:30, Junio C Hamano wrote:
> [email-masked] writes:
> 
> > When a smart HTTP server sends an error message via pkt-line,
> > remote-curl will fail to detect the error (which usually results in
> > incorrectly falling back to dumb-HTTP mode).
> 
> OK, that is a valid thing to worry about.
> 
> >
> > This patch adds a check in discover_refs() for server-side error
> > messages, as well as a test case for this issue.
> 
> This makes me wonder if discoer_refs() is the only place where we
> ought to be checking for ERR packets but we are not.  Are there
> other places that we also need a similar fix?

Quite possibly; I'll review the other client code to see if there are
similar issues before sending v2.