From: "Mazo, Andrey" <amazo@checkvideo•com>
To: "luke@diamand•org" <luke@diamand•org>
Cc: "Mazo, Andrey" <amazo@checkvideo•com>,
"aoakley@roku•com" <aoakley@roku•com>,
"git@vger•kernel.org" <git@vger•kernel.org>,
"gitster@pobox•com" <gitster@pobox•com>,
"merlorom@yahoo•fr" <merlorom@yahoo•fr>,
"szeder.dev@gmail•com" <szeder.dev@gmail•com>,
"vitor.hda@gmail•com" <vitor.hda@gmail•com>
Subject: Re: [PATCHv3 0/2] git-p4: shelved change update with move/copy
Date: Tue, 22 Jan 2019 18:16:02 +0000 [thread overview]
Message-ID: <20190122181547.2172-1-amazo@checkvideo.com> (raw)
In-Reply-To: <20190118093656.16521-1-luke@diamand.org>
> This updates the patchset to support copy, as suggested by Andrey.
>
> Luke Diamand (2):
> git-p4: add failing test for shelved CL update involving move/copy
> git-p4: handle update of moved/copied files when updating a shelve
>
> git-p4.py | 2 ++
> t/t9807-git-p4-submit.sh | 57 +++++++++++++++++++++++++++++++++++++---
> 2 files changed, 56 insertions(+), 3 deletions(-)
Thank you for addressing my comments!
The updated patchset looks good to me:
Acked-by: Andrey Mazo <amazo@checkvideo•com>
Thank you,
Andrey
prev parent reply other threads:[~2019-01-22 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:36 [PATCHv3 0/2] git-p4: shelved change update with move/copy Luke Diamand
2019-01-18 9:36 ` [PATCHv3 1/2] git-p4: add failing test for shelved CL update involving move/copy Luke Diamand
2019-01-18 9:36 ` [PATCHv3 2/2] git-p4: handle update of moved/copied files when updating a shelve Luke Diamand
2019-01-18 17:46 ` [PATCHv3 0/2] git-p4: shelved change update with move/copy Junio C Hamano
2019-01-22 18:16 ` Mazo, Andrey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122181547.2172-1-amazo@checkvideo.com \
--to=amazo@checkvideo$(echo .)com \
--cc=aoakley@roku$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=luke@diamand$(echo .)org \
--cc=merlorom@yahoo$(echo .)fr \
--cc=szeder.dev@gmail$(echo .)com \
--cc=vitor.hda@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox