public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail•com>
To: Paul Schreiber <paulschreiber@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: Bug: subcommand autocomplete fails on 2.21.0
Date: Sat, 6 Apr 2019 23:19:58 +0200	[thread overview]
Message-ID: <20190406211958.GE8796@szeder.dev> (raw)
In-Reply-To: <20190406174929.GD8796@szeder.dev>

On Sat, Apr 06, 2019 at 07:49:29PM +0200, SZEDER Gábor wrote:
> On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote:
> > With git 2.21.0, tab completion no longer works for subcommands.
> > 
> > STEPS TO REPRODUCE
> > 1. install git 2.21.0 from https://git-scm.com/download/mac
> > 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal)
> > 2. git clone https://github.com/tj/git-extras
> > 3. cd git-extras
> > 4. sudo make install
> 
> By the looks of it, this installs five commands whose names start with
> 'del':
> 
>   git-delete-branch
>   git-delete-merged-branches
>   git-delete-submodule
>   git-delete-tag
>   git-delta
> 
> If this is indeed the case, then ...
> 
> > 5. change directory to a git repository
> > 6. type "git del” and press [tab] 
> > 
> > EXPECTED
> > line is changed to "git delete-merged-branches"
> 
> ... this behavior would, in fact, be a bug, because 'del' is the
> unique prefix of those five commands.

Erm, let me rephrase, because this doesn't make sense:

... this behavior would, in fact, be a bug, because 'del' is the
common prefix of those five commands, so it can't be uniquely
completed.

> > ACTUAL
> > [beep]
> 
> And I think this is the right behavior, and on a second TAB it should
> list all commands whose name starts with 'del'.
> 
> > CONFIG
> > macOS 10.13.6 (17G5019) and macOS 10.14 (18E226)
> > git 2.21.0
> > git-extras 4.8.0-dev
> > 
> > REGRESSION
> > Works as expected with git 2.17.0.
> 

      reply	other threads:[~2019-04-06 21:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-06 16:36 Bug: subcommand autocomplete fails on 2.21.0 Paul Schreiber
2019-04-06 17:49 ` SZEDER Gábor
2019-04-06 21:19   ` SZEDER Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190406211958.GE8796@szeder.dev \
    --to=szeder.dev@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=paulschreiber@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox