Subject: Re: [PATCH v4 10/10] list-objects-filter-options: make parser void

From: Matthew DeVore <[email-masked]>
Date: Thu, 27 Jun 2019 15:27:18 -0700

On Thu, Jun 27, 2019 at 02:24:57PM -0700, Matthew DeVore wrote:
> Great. I feel much better about the comments and commit messages now. I
> am about to send a roll-up (v5). Here is the interdiff which catches
> your comments and Dscho's comment about strbuf_addstr:
> 
> <snip>

Forgot to make a string localizable. Add this to the prior interdiff:

diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
index 9e64832a5e..ba1425cb4a 100644
--- a/list-objects-filter-options.c
+++ b/list-objects-filter-options.c
@@ -96,23 +96,24 @@ static int gently_parse_list_objects_filter(
 }
 
 static const char *RESERVED_NON_WS = "~`!@#$^&*()[]{}\\;'\",<>?";
 
 static int has_reserved_character(
 	struct strbuf *sub_spec, struct strbuf *errbuf)
 {
 	const char *c = sub_spec->buf;
 	while (*c) {
 		if (*c <= ' ' || strchr(RESERVED_NON_WS, *c)) {
-			strbuf_addf(errbuf,
-				    "must escape char in sub-filter-spec: '%c'",
-				    *c);
+			strbuf_addf(
+				errbuf,
+				_("must escape char in sub-filter-spec: '%c'"),
+				*c);
 			return 1;
 		}
 		c++;
 	}
 
 	return 0;
 }
 
 static int parse_combine_subfilter(
 	struct list_objects_filter_options *filter_options,