Subject: Re: [PATCH 1/1] t: fix typo in test descriptions

From: Taylor Blau <[email-masked]>
Date: Tue, 5 Nov 2019 23:37:31 -0800

Hi Nathan,

On Wed, Nov 06, 2019 at 04:18:09AM +0000, Nathan Stocks via GitGitGadget wrote:
> From: Nathan Stocks <[email-masked]>
>
> Fix two test descriptions which stated "git -ls-files" when the actual
> command being tested was "git ls-files".
>
> Signed-off-by: Nathan Stocks <[email-masked]>
> ---
>  t/t3060-ls-files-with-tree.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Nice find. I agree with your and Peff's conclusion about when these
might have been introduced, so that they have survived so long indicates
that this was an especially good find indeed.

Your patch looks great to me.

  Reviewed-by: Taylor Blau <[email-masked]>

> diff --git a/t/t3060-ls-files-with-tree.sh b/t/t3060-ls-files-with-tree.sh
> index 44f378ce41..52ed665fcd 100755
> --- a/t/t3060-ls-files-with-tree.sh
> +++ b/t/t3060-ls-files-with-tree.sh
> @@ -47,7 +47,7 @@ test_expect_success setup '
>  	git add .
>  '
>
> -test_expect_success 'git -ls-files --with-tree should succeed from subdir' '
> +test_expect_success 'git ls-files --with-tree should succeed from subdir' '
>  	# We have to run from a sub-directory to trigger prune_path
>  	# Then we finally get to run our --with-tree test
>  	(
> @@ -57,7 +57,7 @@ test_expect_success 'git -ls-files --with-tree should succeed from subdir' '
>  '
>
>  test_expect_success \
> -    'git -ls-files --with-tree should add entries from named tree.' \
> +    'git ls-files --with-tree should add entries from named tree.' \
>      'test_cmp expected output'
>
>  test_done
> --
> gitgitgadget

Thanks,
Taylor