Subject: Re: Protocol v2: The wrong --shallow-since time format causes git to wait indefinitely

From: Denton Liu <[email-masked]>
Date: Tue, 19 Nov 2019 15:36:45 -0800

Hi Junio,

On Wed, Nov 13, 2019 at 12:42:28PM +0900, Junio C Hamano wrote:
> "Force.Charlie" <[email-masked]> writes:
> 
> > # time format wrong
> > git -c protocol.version=2 clone https://github.com/git/git.git --shallow-since=20151012
> 
> That's the valid/right way to specify the timestamp that is
> 20,151,012 seconds after the epoch (i.e. 1970-01-01), isn't it?

I don't think so. When we run the same thing under protocol v1, we get
the following:

	$ git -c protocol.version=1 clone https://github.com/git/git.git --shallow-since=20151012
	Cloning into 'git'...
	fatal: the remote end hung up unexpectedly

even though the following does work:

	$ git -c protocol.version=1 clone https://github.com/git/git.git --shallow-since=2015-10-12
	Cloning into 'git'...
	remote: Enumerating objects: 93982, done.
	...

which suggests to me that the non-dashed form is invalid.

Thanks,

Denton