Subject: Re: [PATCH] t5150: skip request-pull test if Perl is disabled

From: Jonathan Nieder <[email-masked]>
Date: Mon, 25 Nov 2019 16:46:47 -0800

Ruud van Asseldonk wrote:

> The git-request-pull.sh script invokes Perl,

Okay, on second glance I found it:

  set fnord $(git ls-remote "$url" | @@PERL@@ -e "$find_matching_ref" "${remote:-HEAD}" "$headrev")

This does seem pretty inherently to require perl, so makes sense.

I wonder if we can generalize this.  For example, would it make sense to
have a helper that looks for @@PERL@@ in a file,  so we could say

	if uses_perl git-request-pull.sh && ! test_have_prereq PERL
	then
		...
	fi

That way, this would be more futureproof in case someone eliminates
the perl dependency (either by improving that particular parsing step
or by rewriting the whole program in C).

In any event,
Reviewed-by: Jonathan Nieder <[email-masked]>

Do the request-pull tests in t7006-pager.sh need the same treatment?

Thanks,
Jonathan