Subject: Re: [PATCH] test: use test_must_be_empty F instead of test_cmp empty F

From: Denton Liu <[email-masked]>
Date: Tue, 26 Nov 2019 12:02:39 -0800

Hi René,

On Tue, Nov 26, 2019 at 08:46:34PM +0100, René Scharfe wrote:
> Use test_must_be_empty instead of comparing it to an empty file.  That's
> more efficient, as the function only needs built-in meta-data only check
> in the usual case, and provides nicer debug output otherwise.
> 
> Signed-off-by: René Scharfe <[email-masked]>

Nice, I like test cleanup :)

> ---

[...]

> diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
> index 0b20b07e68..3a3d8d3bd5 100755
> --- a/t/t9010-svn-fe.sh
> +++ b/t/t9010-svn-fe.sh
> @@ -53,9 +53,7 @@ text_no_props () {
>  	printf "%s\n" "$text"
>  }
> 
> ->empty
> -
> -test_expect_success 'empty dump' '
> +test_expect_success PIPE 'empty dump' '

How come we need the PIPE prereq here? At the top of this file, we have

	if test_have_prereq !PIPE
	then
		skip_all="svn dumpfile importer testing requires the PIPE prerequisite"
		test_done
	fi

which should guarantee PIPE at this point already.

Thanks,

Denton

>  	reinit_git &&
>  	echo "SVN-fs-dump-format-version: 2" >input &&
>  	try_dump input
> @@ -208,7 +206,7 @@ test_expect_failure 'timestamp and empty file' '
>  	test_cmp expect.date actual.date &&
>  	test_cmp expect.files actual.files &&
>  	git checkout HEAD empty-file &&
> -	test_cmp empty file
> +	test_must_be_empty file
>  '
> 
>  test_expect_success 'directory with files' '
> --
> 2.24.0
>