From: Jonathan Nieder <jrnieder@gmail•com>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org, Emily Shaffer <emilyshaffer@google•com>,
Ramsay Jones <ramsay@ramsayjones•plus.com>
Subject: Re: [PATCH] Makefile: drop GEN_HDRS
Date: Mon, 16 Dec 2019 17:43:21 -0800 [thread overview]
Message-ID: <20191217014321.GF10734@google.com> (raw)
In-Reply-To: <20191216192014.GA2678964@coredump.intra.peff.net>
Jeff King wrote:
> I actually wonder if the whole thing would be simpler if command-list.h
> was a static tracked file with the declarations, and we generated
> command-list.c with "extern const char *command_list[]", etc.
Right, or a "command-list.inc" file.
extern-ing it seems like the simplest way to go.
Thanks,
Jonathan
next prev parent reply other threads:[~2019-12-17 1:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 23:25 [PATCH] Makefile: drop GEN_HDRS Junio C Hamano
2019-12-14 0:38 ` Jeff King
2019-12-14 1:00 ` Jeff King
2019-12-16 18:55 ` Junio C Hamano
2019-12-16 19:20 ` Jeff King
2019-12-17 1:27 ` Emily Shaffer
2019-12-17 1:40 ` Jonathan Nieder
2019-12-17 5:22 ` Jeff King
2019-12-17 1:43 ` Jonathan Nieder [this message]
2019-12-17 5:28 ` Jeff King
2019-12-17 11:35 ` vcxproj target, was " Johannes Schindelin
2019-12-19 4:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217014321.GF10734@google.com \
--to=jrnieder@gmail$(echo .)com \
--cc=emilyshaffer@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ramsay@ramsayjones$(echo .)plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox