Subject: Re: [PATCH v2] format-patch: teach --no-q-encode-headers

From: Emma Brooks <[email-masked]>
Date: Wed, 8 Apr 2020 03:57:20 +0000

On 2020-04-07 14:40:31+0700, Danh Doan wrote:
> > +format.qEncodeHeaders::
> > +	Encode email headers that have non-ASCII characters with
> > +	"Q-encoding" for email transmission. Defaults to true.
> 
> I think have (described in RFC 2047) as same as
> --[no]-q-encode-headers belows would be better.

Agreed. I will reference it there as well.

> > +--q-encode-headers::
> > +--no-q-encode-headers::
> > +	Encode email headers that have non-ASCII characters with
> > +	"Q-encoding" (described in RFC 2047), instead of outputting the
> > +	headers verbatim. The default is set to the value of the
> > +	`format.qEncodeHeaders` configuration variable.
> 
> I find this paragraph hard to understand.
> I think:
> 
> 	If this option is omited, set to value of of ...
> 
> is easier to understand (to me, at least).

OK, I will simplify the language in v3.