public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jonathan Nieder <jrnieder@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Dixit, Ashutosh" <ashutosh.dixit@intel•com>,
	git@vger•kernel.org, Jonathan Tan <jonathantanmy@google•com>,
	Konstantin Ryabitsev <konstantin@linuxfoundation•org>
Subject: Re: Bug in 2.26: git-fetch fetching too many objects?
Date: Tue, 21 Apr 2020 12:36:11 -0700	[thread overview]
Message-ID: <20200421193611.GA103469@google.com> (raw)
In-Reply-To: <xmqqblnkodi4.fsf@gitster.c.googlers.com>

Hi,

Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail•com> writes:
>> Dixit, Ashutosh wrote:

>>> I am seeing a strange behavior in git-fetch in 2.26. I frequently fetch
>>> from a couple of linux kernel remotes (so you will have an idea how big the
>>> repo is). I have a different system with 2.20 on which I never see a
>>> problem.
>> ...
>> I suspect this is related to the change that protocol v2 does to use
>> stateless-rpc even in stateful protocols.  If my suspicion is correct,
>> then the same behavior would show up with protocol v0 over http and
>> https as well.
[...]
> This is at least the fourth time we hear that v2 may not be ready
> for the real-world use.  Perhaps we should revert the default flip
> on the maintenance track while we hunt for bugs and improve the
> protocol support?

That feels to me like an overreaction, since these are all reports of
the same issue that we have a fix to.  Shouldn't we just flip the
default for fetch.negotiationAlgorithm to skipping?  If we revert to
buy time, what would we do with that time?

In other words, if I understand correctly, it's describing an issue
that also exists in protocol v0 for https.  I would be *very*
interested in any evidence one way or another about whether I am
understanding correctly.  If we flip the default, I don't see how
we'll get that evidence, since we've been using protocol v2 as the
default at $DAYJOB for quite a long time now.

Thanks,
Jonathan

next prev parent reply	other threads:[~2020-04-21 19:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 15:44 Bug in 2.26: git-fetch fetching too many objects? Dixit, Ashutosh
2020-04-20 17:03 ` Konstantin Ryabitsev
2020-04-21  5:18   ` Dixit, Ashutosh
2020-04-21  6:45 ` Jonathan Nieder
2020-04-21 19:16   ` Junio C Hamano
2020-04-21 19:36     ` Jonathan Nieder [this message]
2020-04-21 20:06       ` Junio C Hamano
2020-04-21 21:11       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421193611.GA103469@google.com \
    --to=jrnieder@gmail$(echo .)com \
    --cc=ashutosh.dixit@intel$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=jonathantanmy@google$(echo .)com \
    --cc=konstantin@linuxfoundation$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox