Subject: Re: [PATCH 3/5] commit: move 'unregister_shallow' to 'shallow.h'

From: Jonathan Nieder <[email-masked]>
Date: Wed, 29 Apr 2020 20:13:50 -0700

Taylor Blau wrote:

> In the last commit, we introduced a header for the functions defined in
> 'shallow.c'. There is one remaining shallow-related function in
> commit.c which should be moved, too. This patch moves that function.
> 
> Signed-off-by: Taylor Blau <[email-masked]>
> ---
>  commit.c  | 13 -------------
>  shallow.c | 13 +++++++++++++
>  shallow.h |  1 +
>  3 files changed, 14 insertions(+), 13 deletions(-)

Yes, an obviously good thing to do.

Perhaps could be squashed with patch 1 (but also see my review of that
one).

Reviewed-by: Jonathan Nieder <[email-masked]>

Should this take a "struct repository" parameter?