Subject: Re: [PATCH v3 8/8] ci: modification of main.yml to use cmake for vs-build job

From: Đoàn Trần Công Danh <[email-masked]>
Date: Sat, 30 May 2020 21:14:48 +0700

On 2020-05-29 13:40:24+0000, Sibi Siddharthan via GitGitGadget <[email-masked]> wrote:
> To check for ICONV_OMITS_BOM libiconv.dll needs to be in the working
> directory of script or path. So we copy the dlls before we configure.

If ICONV_OMITS_BOM is such a troublemaker for CMake,
I'm fine with not supporting it at all.

It seems like noone except me have interest in ICONV_OMITS_BOM.

> @@ -302,4 +308,4 @@ jobs:
>      steps:
>      - uses: actions/checkout@v1
>      - run: ci/install-dependencies.sh
> -    - run: ci/test-documentation.sh
> +    - run: ci/test-documentation.sh
> \ No newline at end of file

Please fix your editor ;)

-- 
Danh