Subject: Re: [PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return

From: Shourya Shukla <[email-masked]>
Date: Sat, 25 Jul 2020 23:01:18 +0530

> Following 'enum bisect_error' vocabulary, return variable 'res' is
> always non-positive.
> Let's use '-res' instead of 'abs(res)' to make the code clearer.

> Mentored-by: Christian Couder <[email-masked]>
> Signed-off-by: Miriam Rubio <[email-masked]>
> Helped-by: Junio C Hamano <[email-masked]>

Although there is no set rule for this, but I think that your sign-off
goes at the last generally. This is what I have seen on various patches.