Subject: Re: [PATCH v2] Propagate --quiet on submodule update to merge/rebase

From: Jonathan Nieder <[email-masked]>
Date: Wed, 30 Sep 2020 22:38:03 -0700

Junio C Hamano wrote:
> Theodore Dubois <[email-masked]> writes:

>> Without this, commands such as
>> git pull --rebase --recurse-submodules --quiet
>> might produce non-quiet output from the merge or rebase.
>>
>> Also fix the parsing of git submodule update -v. Setting GIT_QUIET to 0
>> has the same effect as setting GIT_QUIET to 1, because
>> ${GIT_QUIET:+--quiet} only checks whether GIT_QUIET is set or unset.
>
> Thanks.
>
> Will queue with the following log message.
>
>     submodule update: silence underlying merge/rebase "--quiet" is given

Missing 'when' before '"--quiet"', as Eric noticed.

Aside from that,
Reviewed-by: Jonathan Nieder <[email-masked]>

Thanks, all.