From: Beat Bolli <dev+git@drbeat•li>
To: paulus@ozlabs•org
Cc: git@vger•kernel.org, Beat Bolli <dev+git@drbeat•li>
Subject: [PATCH] gitk: macOS: ignore osascript errors
Date: Sun, 25 Oct 2020 18:51:49 +0100 [thread overview]
Message-ID: <20201025175149.11853-1-dev+git@drbeat.li> (raw)
Starting gitk on a macOS 10.14.6 (Mojave) system fails with the error
Error in startup script: 2020-10-25 17:16:44.568 osascript[36810:18758270]
Error loading /Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support:
dlopen(/Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support, 0x0106):
code signature in (/Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support)
not valid for use in process: mapping process is a platform binary, but mapped file is not
[[this same message repeated dozens of times]]
while executing
"exec osascript -e [format {
tell application "System Events"
set frontmost of processes whose unix id is %d to true
end te..."
invoked from within
"if {[tk windowingsystem] eq "aqua"} {
exec osascript -e [format {
tell application "System Events"
set frontmost of processes ..."
(file "./gitk" line 12265)
Ignore errors from the osascript invocation, especially because this macOS
version seems to correctly place the gitk window in the foreground.
Signed-off-by: Beat Bolli <dev+git@drbeat•li>
---
gitk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitk b/gitk
index 23d9dd1..8551711 100755
--- a/gitk
+++ b/gitk
@@ -12290,11 +12290,11 @@ if {[catch {package require Tk 8.4} err]} {
# on OSX bring the current Wish process window to front
if {[tk windowingsystem] eq "aqua"} {
- exec osascript -e [format {
+ catch { exec osascript -e [format {
tell application "System Events"
set frontmost of processes whose unix id is %d to true
end tell
- } [pid] ]
+ } [pid] ] }
}
# Unset GIT_TRACE var if set
--
2.28.0
next reply other threads:[~2020-10-25 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 17:51 Beat Bolli [this message]
2020-10-26 17:21 ` [PATCH] gitk: macOS: ignore osascript errors Stefan Haller
2020-10-27 13:02 ` Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201025175149.11853-1-dev+git@drbeat.li \
--to=dev+git@drbeat$(echo .)li \
--cc=git@vger$(echo .)kernel.org \
--cc=paulus@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox