From: Joel Holdsworth <jholdsworth@nvidia•com>
To: git@vger•kernel.org, Luke Diamand <luke@diamand•org>,
Junio C Hamano <gitster@pobox•com>
Cc: Tzadik Vanderhoof <tzadik.vanderhoof@gmail•com>,
Dorgon Chang <dorgonman@hotmail•com>,
Joachim Kuebart <joachim.kuebart@gmail•com>,
Daniel Levin <dendy.ua@gmail•com>,
Johannes Schindelin <johannes.schindelin@gmx•de>,
Ben Keene <seraphire@gmail•com>,
Andrew Oakley <andrew@adoakley•name>,
Joel Holdsworth <jholdsworth@nvidia•com>
Subject: [PATCH v2 RESEND 0/5] git-p4: fix RCS keyword processing encoding errors
Date: Tue, 4 Jan 2022 12:49:08 +0000 [thread overview]
Message-ID: <20220104124913.2894-1-jholdsworth@nvidia.com> (raw)
This patch-set fixes a family of issues with git-p4's handling of
incoming text data that contains RCS keywords, when those files contain
bytes which are invalid UTF-8 codes.
Among the patches is a fix for the issue, as well as some peripheral
tidy-ups and improvements to the existing code.
This patch-set is compatible and has been tested with both Python 2 and
3, and includes a test.
This v2 version of the patch-set separates the read/write mode fix (4/5)
out from the RCS byte processing patch (5/5)
Joel Holdsworth (5):
git-p4: use with statements to close files after use in
patchRCSKeywords
git-p4: pre-compile RCS keyword regexes
git-p4: add raw option to read_pipelines
git-p4: open temporary patch file for write only
git-p4: resolve RCS keywords in bytes not utf-8
git-p4.py | 66 ++++++++++++++++++-------------------------
t/t9810-git-p4-rcs.sh | 15 ++++++++++
2 files changed, 42 insertions(+), 39 deletions(-)
--
2.34.1
next reply other threads:[~2022-01-04 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 12:49 Joel Holdsworth [this message]
2022-01-04 12:49 ` [PATCH v2 RESEND 1/5] git-p4: use with statements to close files after use in patchRCSKeywords Joel Holdsworth
2022-01-04 12:49 ` [PATCH v2 RESEND 2/5] git-p4: pre-compile RCS keyword regexes Joel Holdsworth
2022-01-04 12:49 ` [PATCH v2 RESEND 3/5] git-p4: add raw option to read_pipelines Joel Holdsworth
2022-01-04 12:49 ` [PATCH v2 RESEND 4/5] git-p4: open temporary patch file for write only Joel Holdsworth
2022-01-04 12:49 ` [PATCH v2 RESEND 5/5] git-p4: resolve RCS keywords in bytes not utf-8 Joel Holdsworth
2022-01-04 21:47 ` [PATCH v2 RESEND 0/5] git-p4: fix RCS keyword processing encoding errors Junio C Hamano
2022-01-04 21:59 ` Joel Holdsworth
2022-01-04 22:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104124913.2894-1-jholdsworth@nvidia.com \
--to=jholdsworth@nvidia$(echo .)com \
--cc=andrew@adoakley$(echo .)name \
--cc=dendy.ua@gmail$(echo .)com \
--cc=dorgonman@hotmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=joachim.kuebart@gmail$(echo .)com \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=luke@diamand$(echo .)org \
--cc=seraphire@gmail$(echo .)com \
--cc=tzadik.vanderhoof@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox