From: Jonathan Tan <jonathantanmy@google•com>
To: avarab@gmail•com
Cc: newren@gmail•com, jonathantanmy@google•com, git@vger•kernel.org,
gitster@pobox•com, jabolopes@google•com
Subject: Re: [PATCH v2] sparse-checkout: create leading directory
Date: Mon, 24 Jan 2022 10:25:00 -0800 [thread overview]
Message-ID: <20220124182500.2439823-1-jonathantanmy@google.com> (raw)
In-Reply-To: <220124.86zgnlgyjr.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> The first thing I said in this thread is "Thanks. This fix looks good to
> me.". I'd be happy to have just this fix in. This patch resolves a
> blocked of an earlier series of mine.
>
> The rest of the feedback here (aside from the trivial "rm -rf" fix) was
> an attempt to bridge the gap between this & my earlier look in [1].
>
> > And I think I'd say the same thing even if I saw your tests as being
> > much more closely related to what Jonathan was checking.
> >
> > That's my $0.02 on "why not?". The story totally changes if you want
> > to submit these tests separate from Jonathan's series. If that's the
> > scenario, then I fully agree with you on "it's cheap to add more test
> > coverage so why not include it?"
>
> Sure, or maybe he'd be interested, or not. I'd rather try to suggest
> some small proposed changes than submit a patch of my own as an initial
> approach.
If my patch is OK going in on its own, I'd rather do that, and leave
additional changes to other patch sets.
next prev parent reply other threads:[~2022-01-24 18:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 18:55 [PATCH] sparse-checkout: create leading directory Jonathan Tan
2022-01-20 20:26 ` Junio C Hamano
2022-01-20 21:30 ` Ævar Arnfjörð Bjarmason
2022-01-22 7:58 ` SZEDER Gábor
2022-01-21 17:44 ` [PATCH v2] " Jonathan Tan
2022-01-21 18:48 ` Ævar Arnfjörð Bjarmason
2022-01-22 5:21 ` Elijah Newren
2022-01-22 12:06 ` Ævar Arnfjörð Bjarmason
2022-01-22 17:29 ` Elijah Newren
2022-01-24 11:17 ` Ævar Arnfjörð Bjarmason
2022-01-24 18:25 ` Jonathan Tan [this message]
2022-01-25 5:37 ` Elijah Newren
2022-01-22 2:33 ` Elijah Newren
2022-01-24 18:22 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124182500.2439823-1-jonathantanmy@google.com \
--to=jonathantanmy@google$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jabolopes@google$(echo .)com \
--cc=newren@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox