From: Junio C Hamano <gitster@pobox•com>
To: git@vger•kernel.org
Subject: [PATCH 0/3] Auditing use of xwrite()
Date: Sat, 2 Mar 2024 11:03:45 -0800 [thread overview]
Message-ID: <20240302190348.3946569-1-gitster@pobox.com> (raw)
The xwrite() helper relieves us from having to worry about an
interrupted write(2) system call that returns an EINTR error without
writing any, in which case we need to retry the system call. It,
just as the underlying write(2) system call, however can return
without writing the bytes requested to be written fully. A code
that uses xwrite() and wants to write the full contents of the
buffer needs to take care of such a "short write" situation,
typically by calling xwrite() in a loop.
We recently audited all the calls to xwrite(), and have found two
classes of potential "problems". This miniseries is about fixing them.
* There are such loops around xwrite() as described above, which
were written long time ago. The write_in_full() helper does
implement such a loop in a reusable way, and we should just call
it instead.
* There are xwrite() calls whose return value is ignored. We would
not be able to detect (and complete) "short write" in such callers,
of course, but more importantly, we would not notice I/O failures.
Again, use write_in_full() to deal with short writes, and check
the return value from it to detect errors.
Junio C Hamano (3):
unpack: rewrite hand-rolled loop of xwrite()s with write_in_full()
sideband: avoid short write(2)
repack: check error writing to pack-objects subprocess
builtin/index-pack.c | 17 +++--------------
builtin/repack.c | 5 +++--
builtin/unpack-objects.c | 8 +-------
sideband.c | 4 ++--
4 files changed, 9 insertions(+), 25 deletions(-)
--
2.44.0-84-gb387623c12
next reply other threads:[~2024-03-02 19:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 19:03 Junio C Hamano [this message]
2024-03-02 19:03 ` [PATCH 1/3] unpack: replace xwrite() loop with write_in_full() Junio C Hamano
2024-03-04 6:58 ` Patrick Steinhardt
2024-03-04 7:29 ` Junio C Hamano
2024-03-04 16:43 ` Junio C Hamano
2024-03-02 19:03 ` [PATCH 2/3] sideband: avoid short write(2) Junio C Hamano
2024-03-02 19:03 ` [PATCH 3/3] repack: check error writing to pack-objects subprocess Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302190348.3946569-1-gitster@pobox.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox