From: Meet Soni <meetsoni3017@gmail•com>
To: git@vger•kernel.org
Cc: shubham.kanodia10@gmail•com, Meet Soni <meetsoni3017@gmail•com>
Subject: [PATCH v2 0/3] refspec: centralize refspec-related logic
Date: Mon, 27 Jan 2025 16:06:41 +0530 [thread overview]
Message-ID: <20250127103644.36627-1-meetsoni3017@gmail.com> (raw)
Thank you for reviewing :)
I've added documentation comments for various function signatures to
better understand what they do.
Meet Soni (3):
refspec: relocate omit_name_by_refspec and related functions
refspec: relocate query related functions
refspec: relocate apply_refspecs and related funtions
refspec.c | 203 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
refspec.h | 41 +++++++++++
remote.c | 201 -----------------------------------------------------
remote.h | 15 ----
4 files changed, 244 insertions(+), 216 deletions(-)
Range-diff against v1:
1: 97c98f5a38 ! 1: 8e393ea1c2 refspec: relocate omit_name_by_refspec and related functions
@@ refspec.h: struct strvec;
+ * name matches at least one negative refspec, and 0 otherwise.
+ */
+int omit_name_by_refspec(const char *name, struct refspec *rs);
++
++/*
++ * Checks whether a name matches a pattern and optionally generates a result.
++ * Returns 1 if the name matches the pattern, 0 otherwise.
++ */
+int match_name_with_pattern(const char *key, const char *name,
+ const char *value, char **result);
+
2: 4f0080aad6 ! 2: ef6edbc15b refspec: relocate query related functions
@@ refspec.c: int omit_name_by_refspec(const char *name, struct refspec *rs)
+}
## refspec.h ##
-@@
- #ifndef REFSPEC_H
- #define REFSPEC_H
+@@ refspec.h: struct refspec_item {
+ char *raw;
+ };
-+#include "string-list.h"
++struct string_list;
+
- #define TAG_REFSPEC "refs/tags/*:refs/tags/*"
+ #define REFSPEC_FETCH 1
+ #define REFSPEC_PUSH 0
- /**
@@ refspec.h: int omit_name_by_refspec(const char *name, struct refspec *rs);
int match_name_with_pattern(const char *key, const char *name,
const char *value, char **result);
++/*
++ * Queries a refspec for a match and updates the query item.
++ * Returns 0 on success, -1 if no match is found or negative refspec matches.
++ */
+int query_refspecs(struct refspec *rs, struct refspec_item *query);
++
++/*
++ * Queries a refspec for all matches and appends results to the provided string
++ * list.
++ */
+void query_refspecs_multiple(struct refspec *rs,
+ struct refspec_item *query,
+ struct string_list *results);
3: f89328fa66 ! 3: ea72647439 refspec: relocate apply_refspecs and related funtions
@@ refspec.h: void query_refspecs_multiple(struct refspec *rs,
+ */
+struct ref *apply_negative_refspecs(struct ref *ref_map, struct refspec *rs);
+
++/*
++ * Applies refspecs to a name and returns the corresponding destination.
++ * Returns the destination string if a match is found, NULL otherwise.
++ */
+char *apply_refspecs(struct refspec *rs, const char *name);
+
#endif /* REFSPEC_H */
--
2.34.1
next reply other threads:[~2025-01-27 10:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 10:36 Meet Soni [this message]
2025-01-27 10:36 ` [PATCH v2 1/3] refspec: relocate omit_name_by_refspec and related functions Meet Soni
2025-01-27 17:21 ` Junio C Hamano
2025-01-29 5:15 ` Meet Soni
2025-01-27 10:36 ` [PATCH v2 2/3] refspec: relocate query " Meet Soni
2025-01-27 19:25 ` Junio C Hamano
2025-01-29 6:32 ` Meet Soni
2025-01-27 10:36 ` [PATCH v2 3/3] refspec: relocate apply_refspecs and related funtions Meet Soni
2025-01-27 20:14 ` Junio C Hamano
2025-01-29 7:03 ` Meet Soni
2025-01-27 11:00 ` [PATCH v2 0/3] refspec: centralize refspec-related logic Meet Soni
2025-01-27 18:10 ` Junio C Hamano
2025-01-29 5:18 ` Meet Soni
2025-02-01 6:41 ` [PATCH v3 0/5] " Meet Soni
2025-02-01 6:41 ` [PATCH v3 1/5] refactor(remote): rename function omit_name_by_refspec Meet Soni
2025-02-03 6:45 ` Patrick Steinhardt
2025-02-01 6:41 ` [PATCH v3 2/5] refspec: relocate refname_matches_negative_refspec_item Meet Soni
2025-02-01 6:42 ` [PATCH v3 3/5] refactor(remote): rename query_refspecs functions Meet Soni
2025-02-03 6:46 ` Patrick Steinhardt
2025-02-04 3:39 ` Meet Soni
2025-02-04 13:58 ` Junio C Hamano
2025-02-01 6:42 ` [PATCH v3 4/5] refspec: relocate matching related functions Meet Soni
2025-02-01 6:42 ` [PATCH v3 5/5] refspec: relocate apply_refspecs and related funtions Meet Soni
2025-02-04 4:05 ` [GSoC][PATCH v4 0/5] refspec: centralize refspec-related logic Meet Soni
2025-02-04 4:05 ` [GSoC][PATCH v4 1/5] remote: rename function omit_name_by_refspec Meet Soni
2025-02-04 9:00 ` Karthik Nayak
2025-02-04 13:58 ` Meet Soni
2025-02-06 10:13 ` Karthik Nayak
2025-02-04 4:05 ` [GSoC][PATCH v4 2/5] refspec: relocate refname_matches_negative_refspec_item Meet Soni
2025-02-04 4:05 ` [GSoC][PATCH v4 3/5] remote: rename query_refspecs functions Meet Soni
2025-02-04 4:05 ` [GSoC][PATCH v4 4/5] refspec: relocate matching related functions Meet Soni
2025-02-04 4:05 ` [GSoC][PATCH v4 5/5] refspec: relocate apply_refspecs and related funtions Meet Soni
2025-02-04 7:16 ` [GSoC][PATCH v4 0/5] refspec: centralize refspec-related logic Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127103644.36627-1-meetsoni3017@gmail.com \
--to=meetsoni3017@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=shubham.kanodia10@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox