From: David Aguilar <davvid@gmail•com>
To: git@vger•kernel.org
Cc: "Patrick Steinhardt" <ps@pks•im>,
"Junio C Hamano" <gitster@pobox•com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Jeff King" <peff@peff•net>,
"Phillip Wood" <phillip.wood@dunelm•org.uk>
Subject: [PATCH 2/6] xdiff: avoid signed vs. unsigned comparisons in xdiffi.c
Date: Tue, 11 Feb 2025 22:04:14 -0800 [thread overview]
Message-ID: <20250212060418.1645241-2-davvid@gmail.com> (raw)
In-Reply-To: <20250212060418.1645241-1-davvid@gmail.com>
The loop iteration variable is non-negative and only used in comparisons
against other size_t values.
Signed-off-by: David Aguilar <davvid@gmail•com>
---
xdiff/xdiffi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/xdiff/xdiffi.c b/xdiff/xdiffi.c
index 4685ba6137..8889b8b62a 100644
--- a/xdiff/xdiffi.c
+++ b/xdiff/xdiffi.c
@@ -19,7 +19,6 @@
* Davide Libenzi <davidel@xmailserver•org>
*
*/
-#define DISABLE_SIGN_COMPARE_WARNINGS
#include "xinclude.h"
@@ -1014,7 +1013,7 @@ static void xdl_mark_ignorable_lines(xdchange_t *xscr, xdfenv_t *xe, long flags)
static int record_matches_regex(xrecord_t *rec, xpparam_t const *xpp) {
regmatch_t regmatch;
- int i;
+ size_t i;
for (i = 0; i < xpp->ignore_regex_nr; i++)
if (!regexec_buf(xpp->ignore_regex[i], rec->ptr, rec->size, 1,
--
2.48.1.643.g61982db19f
next prev parent reply other threads:[~2025-02-12 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 6:04 [PATCH 1/6] xdiff: move sign comparison warning guard into each file David Aguilar
2025-02-12 6:04 ` David Aguilar [this message]
2025-02-12 6:04 ` [PATCH 3/6] xdiff: avoid signed vs. unsigned comparisons in xemit.c David Aguilar
2025-02-12 6:04 ` [PATCH 4/6] xdiff: avoid signed vs. unsigned comparisons in xhistogram.c David Aguilar
2025-02-12 6:04 ` [PATCH 5/6] xdiff: avoid signed vs. unsigned comparisons in xpatience.c David Aguilar
2025-02-12 6:04 ` [PATCH 6/6] xdiff: avoid signed vs. unsigned comparisons in xutils.c David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212060418.1645241-2-davvid@gmail.com \
--to=davvid@gmail$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox