From: Jeff King <peff@peff•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Jean-Noël AVILA" <jn.avila@free•fr>,
git@vger•kernel.org,
"Kristoffer Haugsbakk" <code@khaugsbakk•name>
Subject: Re: [PATCH v2] doc: change the markup of paragraphs following a nested list item
Date: Fri, 10 Oct 2025 18:23:04 -0400 [thread overview]
Message-ID: <20251010222304.GA2007405@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqo6qeag9n.fsf@gitster.g>
On Fri, Oct 10, 2025 at 09:11:16AM -0700, Junio C Hamano wrote:
> >> diff --git a/Documentation/config/extensions.adoc
> >> b/Documentation/config/extensions.adoc index 49a7598ca5..aaea8c107f 100644
> >> --- a/Documentation/config/extensions.adoc
> >> +++ b/Documentation/config/extensions.adoc
> >> @@ -55,8 +55,9 @@ For historical reasons, this extension is respected
> > regardless of
> >> the refStorage:::
> >> Specify the ref storage format to use. The acceptable values are:
> >> +
> >> +--
> >> include::../ref-storage-format.adoc[]
> >> -
> >> +--
> >> +
> >> Note that this setting should only be set by linkgit:git-init[1] or
> >> linkgit:git-clone[1]. Trying to change it after initialization will not
> >>
> >> on top of your patch seems to do the right thing (no change in asciidoc,
> >> and eliminating the regression from your patch). It's a little gross
> >> because we are reaching across the include to realize that
> >> ref-storage-format.adoc contains a list that needs to go into its own
> >> block. I wonder if asciidoc implicitly opens a new block for an include
> >> but asciidoctor doesn't. But at any rate, this is the only way I could
> >> come up with for both to render correctly.
> >
> > Thank you for cross-checking. This is indeed almost impossible to mechanize
> > such testing at the moment.
>
> Thanks, both.
>
> So we'd see an update to this (I think this is already in 'next')?
I think we already did, in:
https://lore.kernel.org/git/20251007082223.GA3336685@coredump.intra.peff.net/
and you queued that on the topic (and merged it to next already). Or am
I misunderstanding the question?
-Peff
next prev parent reply other threads:[~2025-10-10 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 18:34 doc: config/extensions.adoc: line continuation syntax error Kristoffer Haugsbakk
2025-09-23 21:08 ` Jean-Noël AVILA
2025-09-24 0:54 ` Jeff King
2025-09-26 19:40 ` [PATCH] doc: change the markup of paragraphs following a nested list item Jean-Noël Avila
2025-09-26 20:54 ` Junio C Hamano
2025-09-27 19:39 ` [PATCH v2] " Jean-Noël Avila
2025-09-28 15:35 ` Junio C Hamano
2025-10-03 3:11 ` Jeff King
2025-10-03 3:41 ` Jeff King
2025-10-03 16:29 ` Junio C Hamano
2025-10-04 17:31 ` Jean-Noël AVILA
2025-10-10 16:11 ` Junio C Hamano
2025-10-10 22:23 ` Jeff King [this message]
2025-10-13 15:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010222304.GA2007405@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=code@khaugsbakk$(echo .)name \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jn.avila@free$(echo .)fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox