From: Jeff King <peff@peff•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: Patrick Steinhardt <ps@pks•im>, git@vger•kernel.org
Subject: Re: What's cooking in git.git (Oct 2025, #12; Thu, 30)
Date: Mon, 3 Nov 2025 16:30:59 -0500 [thread overview]
Message-ID: <20251103213059.GA2528366@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq7bw6ubaw.fsf@gitster.g>
On Mon, Nov 03, 2025 at 12:10:47PM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox•com> writes:
>
> > Bisect points at 054f5f45 (ref-filter: parse objects on demand,
> > 2025-10-23), which is unfortunate, as that is the motivating step of
> > the whole topic.
>
> Here is a fairly simple reproduction. It appears that this does not
> require the refs to be packed (i.e., "t7004-tag.sh -i -v" fails
> after saying "*** Loose ***" here, without moving to the packed
> test).
I think the issue is that nobody ever resets data->maybe_object. So it
is left cached with the very first object that gets looked up.
Something like this seems to fix it, but there may be a better place to
do the reset.
diff --git a/ref-filter.c b/ref-filter.c
index 7cfcd5c355..4c174f7ecc 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -2124,6 +2124,8 @@ static int grab_values(struct atom_value *val, int deref, struct expand_data *da
void *buf = data->content;
int ret;
+ data->maybe_object = NULL;
+
switch (data->type) {
case OBJ_TAG:
ret = grab_tag_values(val, deref, data, refname, err, eaten);
-Peff
next prev parent reply other threads:[~2025-11-03 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 21:36 What's cooking in git.git (Oct 2025, #12; Thu, 30) Junio C Hamano
2025-10-31 6:42 ` Patrick Steinhardt
2025-10-31 15:51 ` Junio C Hamano
2025-10-31 17:33 ` Eric Sunshine
2025-11-03 14:50 ` Lucas Seiki Oshiro
2025-11-03 17:57 ` Junio C Hamano
2025-11-03 18:43 ` Junio C Hamano
2025-11-03 20:10 ` Junio C Hamano
2025-11-03 21:30 ` Jeff King [this message]
2025-11-04 12:40 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103213059.GA2528366@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox