From: Toon Claes <toon@iotcl•com>
To: git@vger•kernel.org
Cc: Patrick Steinhardt <ps@pks•im>, Toon Claes <toon@iotcl•com>
Subject: [PATCH 2/2] meson: only detect ICONV_OMITS_BOM if possible
Date: Tue, 02 Dec 2025 11:48:09 +0100 [thread overview]
Message-ID: <20251202-toon-cross-compile-v1-2-cabc8bce529f@iotcl.com> (raw)
In-Reply-To: <20251202-toon-cross-compile-v1-0-cabc8bce529f@iotcl.com>
In our Meson setup it automatically detects whether ICONV_OMITS_BOM
should be defined. To check this, a piece of code is compiled and ran.
When cross-compiling, it's not possible to run this piece of code. Guard
this test with a can_run_host_binaries() check to ensure it can run.
Signed-off-by: Toon Claes <toon@iotcl•com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index f1b3615659..95348e69a4 100644
--- a/meson.build
+++ b/meson.build
@@ -1064,7 +1064,7 @@ if iconv.found()
}
'''
- if compiler.run(iconv_omits_bom_source,
+ if meson.can_run_host_binaries() and compiler.run(iconv_omits_bom_source,
dependencies: iconv,
name: 'iconv omits BOM',
).returncode() != 0
--
2.52.0
next prev parent reply other threads:[~2025-12-02 10:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 10:48 [PATCH 0/2] Few fixes for cross-compiling with Meson Toon Claes
2025-12-02 10:48 ` [PATCH 1/2] meson: ignore subprojects/.wraplock Toon Claes
2025-12-02 10:48 ` Toon Claes [this message]
2025-12-02 20:27 ` [PATCH 2/2] meson: only detect ICONV_OMITS_BOM if possible Patrick Steinhardt
2025-12-03 14:55 ` Toon Claes
2025-12-03 14:53 ` [PATCH 3/2] meson: use is_cross_build() where possible Toon Claes
2025-12-04 6:16 ` Patrick Steinhardt
2025-12-07 10:17 ` [PATCH 0/2] Few fixes for cross-compiling with Meson Carlo Marcelo Arenas Belón
2025-12-08 14:41 ` Toon Claes
2025-12-09 0:44 ` Carlo Arenas
2025-12-11 11:10 ` Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251202-toon-cross-compile-v1-2-cabc8bce529f@iotcl.com \
--to=toon@iotcl$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox