From: Patrick Steinhardt <ps@pks•im>
To: git@vger•kernel.org
Cc: Justin Tobler <jltobler@gmail•com>,
Eric Sunshine <sunshine@sunshineco•com>
Subject: [PATCH v2 0/2] Some random object database related fixes
Date: Thu, 11 Dec 2025 08:19:57 +0100 [thread overview]
Message-ID: <20251211-odb-related-fixes-v2-0-bdf875ce51fc@pks.im> (raw)
In-Reply-To: <20251205-odb-related-fixes-v1-0-ef4250abb584@pks.im>
Hi,
this patch series fixes some small issues I've discovered while working
on some other patch series. I've decided to split it out of these
because I'm hitting the same issues in multiple series, and I don't want
those to become dependent on one another.
The patch series is built on top of f0ef5b6d9b with
ps/object-source-management at ac65c70663 (odb: handle recreation of
quarantine directories, 2025-11-19) merged into it.
Changes in v2:
- Drop the first commit that regards geometric repacking with promisor
remotes. As it turns out my assertion was wrong: geometric repacks
do and have to consider promisors, but they will fail to handle
them. This is a bigger topic to fix though, so I'll rather want to
move this into a separate patch series.
- Tighten tests a bit for the commit-graph generation.
- Stop referring to a "subsequent" commit that doesn't exist.
- Link to v1: https://lore.kernel.org/r/20251205-odb-related-fixes-v1-0-ef4250abb584@pks.im
Thanks!
Patrick
---
Patrick Steinhardt (2):
builtin/gc: fix condition for whether to write commit graphs
odb: properly close sources before freeing them
builtin/gc.c | 8 +++++---
odb.c | 2 +-
t/t7900-maintenance.sh | 25 +++++++++++++++++++++++++
3 files changed, 31 insertions(+), 4 deletions(-)
Range-diff versus v1:
1: 5c15065406 < -: ---------- builtin/repack: fix geometric repacks with promisor remotes
2: 2fa3991003 ! 1: 1702bf6e7f builtin/gc: fix condition for whether to write commit graphs
@@ t/t7900-maintenance.sh: test_expect_success 'commit-graph auto condition' '
+ git commit --allow-empty -m main-1 &&
+ git commit --allow-empty -m main-2 &&
+ git merge feature &&
-+ git branch -D feature &&
+
+ # We have 6 commit, none of which are covered by a commit
+ # graph. So this must be the boundary at which we start to
3: a06d0716c3 ! 2: 7dd4e6fabe odb: properly close sources before freeing them
@@ Metadata
## Commit message ##
odb: properly close sources before freeing them
- In the next commit we are about to move the packfile store into the ODB
- source so that we have one store per source. This will lead to a memory
- leak in the following commit when reading data from a submodule via
- git-grep(1):
+ It is possible to hit a memory leak when reading data from a submodule
+ via git-grep(1):
Direct leak of 192 byte(s) in 1 object(s) allocated from:
#0 0x55555562e726 in calloc (git+0xda726)
---
base-commit: 2797238193944b52d12624a04a962f40b9bcad69
change-id: 20251205-odb-related-fixes-5f48a0993ef7
next prev parent reply other threads:[~2025-12-11 7:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 8:19 [PATCH 0/3] Some random object database related fixes Patrick Steinhardt
2025-12-05 8:19 ` [PATCH 1/3] builtin/repack: fix geometric repacks with promisor remotes Patrick Steinhardt
2025-12-10 19:31 ` Justin Tobler
2025-12-11 5:46 ` Patrick Steinhardt
2025-12-05 8:19 ` [PATCH 2/3] builtin/gc: fix condition for whether to write commit graphs Patrick Steinhardt
2025-12-10 19:49 ` Justin Tobler
2025-12-11 5:48 ` Patrick Steinhardt
2025-12-05 8:20 ` [PATCH 3/3] odb: properly close sources before freeing them Patrick Steinhardt
2025-12-05 23:14 ` Eric Sunshine
2025-12-06 11:38 ` Patrick Steinhardt
2025-12-06 11:43 ` Eric Sunshine
2025-12-06 12:04 ` Patrick Steinhardt
2025-12-11 7:19 ` Patrick Steinhardt [this message]
2025-12-11 7:19 ` [PATCH v2 1/2] builtin/gc: fix condition for whether to write commit graphs Patrick Steinhardt
2025-12-11 14:16 ` Toon Claes
2026-01-06 11:27 ` Karthik Nayak
2026-01-06 11:55 ` Patrick Steinhardt
2026-01-06 16:33 ` Karthik Nayak
2025-12-11 7:19 ` [PATCH v2 2/2] odb: properly close sources before freeing them Patrick Steinhardt
2025-12-12 15:01 ` [PATCH v2 0/2] Some random object database related fixes Justin Tobler
2026-01-06 11:29 ` Karthik Nayak
2026-01-06 12:58 ` [PATCH v3 " Patrick Steinhardt
2026-01-06 12:58 ` [PATCH v3 1/2] builtin/gc: fix condition for whether to write commit graphs Patrick Steinhardt
2026-01-06 12:58 ` [PATCH v3 2/2] odb: properly close sources before freeing them Patrick Steinhardt
2026-01-06 16:30 ` [PATCH v3 0/2] Some random object database related fixes Karthik Nayak
2026-01-07 3:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211-odb-related-fixes-v2-0-bdf875ce51fc@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=jltobler@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox