From: Jeff King <peff@peff•net>
To: jim.cromie@gmail•com
Cc: Jason Baron <jbaron@akamai•com>,
git@vger•kernel.org, linux-kernel@vger•kernel.org,
dri-devel@lists•freedesktop.org, gregkh@linuxfoundation•org,
ukaszb@chromium•org, louis.chauvet@bootlin•com
Subject: Re: [PATCH v6 00/31] drm/dyndbg: Fix dynamic debug classmap regression
Date: Mon, 15 Dec 2025 03:07:36 -0500 [thread overview]
Message-ID: <20251215080736.GA809641@coredump.intra.peff.net> (raw)
In-Reply-To: <CAJfuBxx-_Z_hCoqdj2Lma7oP6LhCM6Pz=afe2P=wKO41T7R3mA@mail.gmail.com>
On Mon, Dec 15, 2025 at 11:52:38AM +1300, jim.cromie@gmail•com wrote:
> using the mbox.gz from your link, I get a different failure, this time
> on patch 11
> [...]
> jimc@frodo:~/projects/lx/linux.git$ gunzip
> ~/Downloads/PATCH-v6-00-31-drm-dyndbg-Fix-dynamic-debug-classmap-regression.mbox.gz
> gzip: /home/jimc/Downloads/PATCH-v6-00-31-drm-dyndbg-Fix-dynamic-debug-classmap-regression.mbox
> already exists; do you wish to overwrite (y or n)? y
> jimc@frodo:~/projects/lx/linux.git$ git am --empty=drop
Ah, that is the difference: you are applying directly from the
downloaded mbox file, whereas I picked out the messages using mutt.
The mbox provided by lore is generally in the order the messages were
received, which does not necessarily correspond to the order they were
sent, or the rfc822 dates, or the subject lines. But "git am" does not
do any sorting; it applies the messages in the order it finds them in
the input mbox. So you get out-of-order patch application.
There's another possible gotcha, as well. The mbox for the thread will
contain other non-patch messages like the cover letter and any review
responses. Adding --empty=drop as you did will generally skip past
those, but not always. If somebody responds and says "Maybe do it like
this" with an inline patch, then "git am" will pick up that patch, too!
It worked for me because when I picked the patches out of the thread in
mutt, it showed them sorted by rfc822 date header and used that same
ordering to dump them to the new, filtered mbox. And of course I
manually decided on which messages were part of the patch series and
excluded the rest (based on subject lines).
It would probably be possible to teach "git am" to sort by date header,
but that's not always right, either (you could have a local series with
out-of-order author dates due to rebasing). You could use the subject
lines as heuristics, if you know that the sender didn't use any exotic
format-patch options. So there are probably some heuristics at play.
And none of those ideas helps with the selection problem, which is
another heuristics ball of wax.
Fortunately, I think b4 has melted that wax for us already (OK, maybe
I'm losing the metaphor). If you do:
b4 mbox https://lore.kernel.org/lkml/20251118201842.1447666-1-jim.cromie@gmail.com/
you'll get that unordered mbox again. But if you use the "am" command:
b4 am https://lore.kernel.org/lkml/20251118201842.1447666-1-jim.cromie@gmail.com/
it figures everything out and gives you the clean series in an mbox. It
also knows how to pick the latest version of the series (your v6 is in
its own thread here, but if it were in a thread with v1..v5, you again
get into another message-selection problem).
-Peff
prev parent reply other threads:[~2025-12-15 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251118201842.1447666-1-jim.cromie@gmail.com>
[not found] ` <76038c97-39ca-4672-adc0-4e8fe0e39fc8@akamai.com>
[not found] ` <CAJfuBxxFWD0rEjm-va+Bjmf-m2nfOD_+ZEqKy22WX6QdugQCUw@mail.gmail.com>
[not found] ` <5b3d492c-7037-45a5-a001-0064f14d5f81@akamai.com>
2025-12-14 18:24 ` [PATCH v6 00/31] drm/dyndbg: Fix dynamic debug classmap regression jim.cromie
2025-12-14 19:54 ` Jeff King
2025-12-14 22:52 ` jim.cromie
2025-12-15 8:07 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251215080736.GA809641@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=git@vger$(echo .)kernel.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jbaron@akamai$(echo .)com \
--cc=jim.cromie@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=louis.chauvet@bootlin$(echo .)com \
--cc=ukaszb@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox