From: "René Scharfe" <l.s.r@web•de>
To: git@vger•kernel.org
Subject: [PATCH 1/4] tag: use algo of repo parameter in parse_tag_buffer()
Date: Sun, 28 Dec 2025 19:10:48 +0100 [thread overview]
Message-ID: <20251228181051.68724-2-l.s.r@web.de> (raw)
In-Reply-To: <20251228181051.68724-1-l.s.r@web.de>
Stop using "the_hash_algo" explicitly and implictly via parse_oid_hex()
and instead use the "hash_algo" member of the passed in repository,
which is more correct.
Signed-off-by: René Scharfe <l.s.r@web•de>
---
tag.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tag.c b/tag.c
index f5c232d2f1..dec5ea8eb0 100644
--- a/tag.c
+++ b/tag.c
@@ -148,9 +148,11 @@ int parse_tag_buffer(struct repository *r, struct tag *item, const void *data, u
FREE_AND_NULL(item->tag);
}
- if (size < the_hash_algo->hexsz + 24)
+ if (size < r->hash_algo->hexsz + 24)
return -1;
- if (memcmp("object ", bufptr, 7) || parse_oid_hex(bufptr + 7, &oid, &bufptr) || *bufptr++ != '\n')
+ if (memcmp("object ", bufptr, 7) ||
+ parse_oid_hex_algop(bufptr + 7, &oid, &bufptr, r->hash_algo) ||
+ *bufptr++ != '\n')
return -1;
if (!starts_with(bufptr, "type "))
--
2.52.0
next prev parent reply other threads:[~2025-12-28 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-28 18:10 [PATCH 0/4] tag: stop using the_repository René Scharfe
2025-12-28 18:10 ` René Scharfe [this message]
2025-12-30 16:51 ` [PATCH 1/4] tag: use algo of repo parameter in parse_tag_buffer() Kristoffer Haugsbakk
2025-12-28 18:10 ` [PATCH 2/4] tag: support arbitrary repositories in gpg_verify_tag() René Scharfe
2025-12-28 18:10 ` [PATCH 3/4] tag: support arbitrary repositories in parse_tag() René Scharfe
2025-12-28 18:10 ` [PATCH 4/4] tag: stop using the_repository René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251228181051.68724-2-l.s.r@web.de \
--to=l.s.r@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox