public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail•com>
To: gitster@pobox•com
Cc: git@vger•kernel.org, pushkarkumarsingh1970@gmail•com
Subject: Re: [PATCH] doc: MyFirstContribution: fix missing dependencies and clarify build steps
Date: Tue, 13 Jan 2026 00:40:08 +0530	[thread overview]
Message-ID: <20260112191029.376820-1-shreyanshpaliwalcmsmn@gmail.com> (raw)
In-Reply-To: <xmqqbjiymzpq.fsf@gitster.g>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1084 bytes --]

> >> I personally find that stopping at asciidoc and let the user deal
> >> with their platform convention to get asciidoc working, like the
> >> current documentation does, draws the line better than the above
> >> updated text.
> > ...
> > Please let me know what would be the appropriate approach with this.
> 
> Again, I personally find that stopping at asciidoc and letting the
> user deal with their platform convention to get asciidoc working,
> like the current documentation does, draws the line better.
> 
> If we are not mentioning to check INSTALL elsewhere in the
> instruction, we probably should, and the place where we mention what
> software you need to install (like compilers, make, etc.) would be
> more appropriate, than a note about building documentation.
> 
> Thanks.

Since INSTALL is already referenced near the beginning of the document,
I will drop the additional mention there and keep the instructions as before
in the building documentation part.

I’ll update the patch accordingly and send a v2.

Thanks for the review and guidance.

Best,
Shreyansh

next prev parent reply	other threads:[~2026-01-12 19:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 17:40 [PATCH] Documentation/MyFirstContribution: add missing dependencies and clarify build steps Shreyansh Paliwal
2026-01-12  9:40 ` [PATCH] doc: MyFirstContribution: fix " Shreyansh Paliwal
2026-01-12 12:55   ` Pushkar Singh
2026-01-12 16:05     ` Shreyansh Paliwal
2026-01-12 14:34   ` Junio C Hamano
2026-01-12 16:11     ` Shreyansh Paliwal
2026-01-12 18:51       ` Junio C Hamano
2026-01-12 19:10         ` Shreyansh Paliwal [this message]
2026-01-12 19:53           ` [PATCH v2] " Shreyansh Paliwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260112191029.376820-1-shreyanshpaliwalcmsmn@gmail.com \
    --to=shreyanshpaliwalcmsmn@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=pushkarkumarsingh1970@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox