From: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail•com>
To: git@vger•kernel.org
Cc: gitster@pobox•com, ps@pks•im, sandals@crustytoothpaste•net
Subject: Re: [PATCH] show-index: warn when falling back to SHA-1 outside a repository
Date: Fri, 30 Jan 2026 14:34:53 +0530 [thread overview]
Message-ID: <20260130090525.254665-1-shreyanshpaliwalcmsmn@gmail.com> (raw)
In-Reply-To: <aXvpSPpfvulKu57P@fruit.crustytoothpaste.net>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1183 bytes --]
> On 2026-01-29 at 15:36:55, Shreyansh Paliwal wrote:
> > /*
> > * Fallback to SHA1 if we are running outside of a repository.
> > *
> > - * TODO: Figure out and implement a way to detect the hash algorithm in use by the
> > - * the index file passed in and use that instead.
> > + * TODO: If a future implementation of index file version encodes the hash
> > + * algorithm in its header, enable show-index to infer it from the
> > + * header rather than relying on repository context or a default fallback.
> > */
> > - if (!the_hash_algo)
> > + if (!the_hash_algo) {
> > + warning(_("assuming SHA-1; use --object-format to override"));
> > repo_set_hash_algo(the_repository, GIT_HASH_DEFAULT);
>
> If we're going to start producing a warning, can we also learn a
> `--quiet` option to silence it?
Hi,
That is a good point.
However, the warning is only shown for a particular usecase: when
'git show-index' is run outside of a repository and --object-format
is not specified. Given that narrow scope, I’m wondering whether
adding a dedicated --quiet option for only this warning would be worthwhile.
Let me know what you think :)
Best,
Shreyansh
next prev parent reply other threads:[~2026-01-30 9:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 14:05 [RFC][PATCH 0/3] show-index: modernize and implement auto-detection of hash algorithm Shreyansh Paliwal
2026-01-20 14:05 ` [PATCH 1/3] show-index: implement automatic hash detection Shreyansh Paliwal
2026-01-20 18:07 ` Junio C Hamano
2026-01-21 8:09 ` Patrick Steinhardt
2026-01-21 10:31 ` Shreyansh Paliwal
2026-01-23 7:22 ` Patrick Steinhardt
2026-01-23 16:08 ` Shreyansh Paliwal
2026-01-23 20:29 ` brian m. carlson
2026-01-21 10:28 ` Shreyansh Paliwal
2026-01-20 14:05 ` [PATCH 2/3] show-index: use gettext wrapping in error messages Shreyansh Paliwal
2026-01-20 14:05 ` [PATCH 3/3] show-index: remove global state variables Shreyansh Paliwal
2026-01-21 10:39 ` Phillip Wood
2026-01-21 12:47 ` Shreyansh Paliwal
2026-01-21 17:23 ` Junio C Hamano
2026-01-29 15:36 ` [PATCH] show-index: warn when falling back to SHA-1 outside a repository Shreyansh Paliwal
2026-01-29 23:03 ` Junio C Hamano
2026-01-30 8:59 ` Shreyansh Paliwal
2026-01-29 23:12 ` brian m. carlson
2026-01-30 9:04 ` Shreyansh Paliwal [this message]
2026-01-30 13:40 ` Patrick Steinhardt
2026-01-30 17:01 ` Junio C Hamano
2026-01-30 15:31 ` [PATCH V2 0/2] show-index: add warning and wrap error messages with gettext Shreyansh Paliwal
2026-01-30 15:31 ` [PATCH V2 1/2] show-index: warn when falling back to SHA-1 outside a repository Shreyansh Paliwal
2026-01-30 15:31 ` [PATCH V2 2/2] show-index: use gettext wrapping in user facing error messages Shreyansh Paliwal
2026-01-30 17:07 ` [PATCH V2 0/2] show-index: add warning and wrap error messages with gettext Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260130090525.254665-1-shreyanshpaliwalcmsmn@gmail.com \
--to=shreyanshpaliwalcmsmn@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox