From: Jeff King <peff@peff•net>
To: "D. Ben Knoble" <ben.knoble@gmail•com>
Cc: Patrick Steinhardt <ps@pks•im>, Mirko Faina <mroik@delayed•space>,
Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org
Subject: Re: [PATCH v2] format-patch: fix From header in cover letter
Date: Thu, 19 Feb 2026 06:29:18 -0500 [thread overview]
Message-ID: <20260219112918.GB3529@coredump.intra.peff.net> (raw)
In-Reply-To: <CALnO6CD6c36ur4cxqNAB=Jy=m6yxVfoSzAAekewQZr2vjjKn2w@mail.gmail.com>
On Tue, Feb 17, 2026 at 08:21:32AM -0500, D. Ben Knoble wrote:
> > I think that wording comes from me back in 2013, and I just never gave
> > any thought to cover-letter generation by format-patch itself. I never
> > use it (and I probably forgot it even existed, given that most people
> > would use send-email's cover letter generation, and I do my own thing
> > with mutt).
>
> Funny: the send-email manual's main mention of cover letters apart
> from setting Cc/To fields is in an example…
>
> $ git format-patch --cover-letter -M origin/master -o outgoing/
> $ edit outgoing/0000-*
> $ git send-email outgoing/*
>
> …using format-patch! (Which is how I generate cover letters, and
> probably part of why.)
I think I may be showing my clueless-ness about send-email here. I
thought it had its own cover-letter code, but looking at it briefly, I
may just be wrong. I don't see any code, so I guess people generate the
cover-letter independently with format-patch.
Maybe nobody noticed because most people do not use "--from=<foo>" with
a <foo> that does not match the committer ident in the first place. I'm
not really sure why you'd want the two to differ. Which makes me wonder
why I added that feature in the first place (as opposed to just "--from"
with no options).
Mysteries of the cosmos, I guess.
-Peff
next prev parent reply other threads:[~2026-02-19 11:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 5:49 [PATCH] format-patch: fix from header in cover letter Mirko Faina
2026-02-16 11:01 ` Junio C Hamano
2026-02-16 15:27 ` [PATCH v2] format-patch: fix From " Mirko Faina
2026-02-17 6:22 ` Patrick Steinhardt
2026-02-17 6:34 ` Jeff King
2026-02-17 13:21 ` D. Ben Knoble
2026-02-19 11:29 ` Jeff King [this message]
2026-02-19 12:03 ` Mirko Faina
2026-02-19 13:43 ` D. Ben Knoble
2026-02-17 15:22 ` Junio C Hamano
2026-02-19 11:43 ` Jeff King
2026-02-20 18:11 ` Junio C Hamano
2026-02-17 22:04 ` [PATCH] " Mroik
2026-02-17 22:13 ` Mirko Faina
2026-02-17 22:43 ` Junio C Hamano
2026-02-17 22:41 ` Junio C Hamano
2026-02-17 23:25 ` [PATCH v4] " Mirko Faina
-- strict thread matches above, loose matches on Subject: below --
2026-02-17 21:30 [PATCH v2] " Mirko Faina
2026-02-17 21:41 Mirko Faina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219112918.GB3529@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=ben.knoble@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mroik@delayed$(echo .)space \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox