From: Adrian Ratiu <adrian.ratiu@collabora•com>
To: git@vger•kernel.org
Cc: Junio C Hamano <gitster@pobox•com>,
Patrick Steinhardt <ps@pks•im>,
Emily Shaffer <emilyshaffer@google•com>,
Jeff King <peff@peff•net>,
Adrian Ratiu <adrian.ratiu@collabora•com>
Subject: [PATCH 0/1] Fix update hook perf regression in next
Date: Mon, 2 Mar 2026 21:17:03 +0200 [thread overview]
Message-ID: <20260302191704.1814567-1-adrian.ratiu@collabora.com> (raw)
Hello everyone,
This fixes a performance regression I introduced in next by
removing the "exit early" check for hooks which output over
a sideband, during the conversion to the new hook API.
That was unintentional and these hooks should continue to exit
early if no hook is found, to avoid unnecessarily spinning
un/down async threads which no-op and just add overhead.
Reported by Patrick at [1] and independently root caused and
confirmed by Peff who fixed it in a very similar manner [2].
Pushed to GitHub [3] and succesfully ran the CI [4].
1: https://lore.kernel.org/git/aaWeSu-d1FMz_sW8@pks.im/T/#m4a1e62b3149825ef03f9b5b48f478933abc521cd
2: https://lore.kernel.org/git/aaWeSu-d1FMz_sW8@pks.im/T/#me0d2655bb53f5ca8fc8f31e5726ecf4d2971fa11
3: https://github.com/10ne1/git/tree/refs/heads/dev/aratiu/update-regression-fix
4: https://github.com/10ne1/git/actions/runs/22590151068
Adrian Ratiu (1):
builtin/receive-pack: avoid spinning no-op sideband_async threads
builtin/receive-pack.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
--
2.52.0.732.gb351b5166d.dirty
next reply other threads:[~2026-03-02 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 19:17 Adrian Ratiu [this message]
2026-03-02 19:17 ` [PATCH 1/1] builtin/receive-pack: avoid spinning no-op sideband async threads Adrian Ratiu
2026-03-02 21:40 ` Junio C Hamano
2026-03-03 12:47 ` Adrian Ratiu
2026-03-03 6:11 ` Patrick Steinhardt
2026-03-03 12:45 ` Adrian Ratiu
2026-03-03 13:28 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302191704.1814567-1-adrian.ratiu@collabora.com \
--to=adrian.ratiu@collabora$(echo .)com \
--cc=emilyshaffer@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox