Subject: [PATCH v2 0/5] oidmap: migrate cleanup to oidmap_clear_with_free()

From: Seyi Kuforiji <[email-masked]>
Date: Mon, 2 Mar 2026 21:00:12 +0100

Hi,

This series replaces oidmap_clear(map, 1) with
oidmap_clear_with_free() and introduces explicit free callbacks
at the remaining call sites.

The old boolean-based API implicitly assumed plain free(),
which obscures ownership semantics and does not work well
when oidmap_entry is embedded inside larger structures.
The callback-based API makes cleanup explicit and type-safe,
and avoids relying on hidden assumptions about allocation.

This is used in subsequent commits to adequately cleanup all
usage site.

Changes in v2:
 - fix missing .path cleanup
 - modified commit message to be more accurate

Thanks
Seyi

Seyi Kufoiji (5):
  oidmap: make entry cleanup explicit in oidmap_clear
  builtin/rev-list: migrate missing_objects cleanup to
    oidmap_clear_with_free()
  list-objects-filter: use oidmap_clear_with_free() for cleanup
  odb: use oidmap_clear_with_free() to release replace_map entries
  sequencer: use oidmap_clear_with_free() for string_entry cleanup

 builtin/rev-list.c      | 15 ++++++++++++---
 list-objects-filter.c   |  9 ++++++++-
 odb.c                   | 11 ++++++++++-
 oidmap.c                | 23 ++++++++++++++++++++---
 oidmap.h                | 15 +++++++++++++++
 sequencer.c             | 10 ++++++++--
 t/unit-tests/u-oidmap.c | 41 +++++++++++++++++++++++++++++++++++++++++
 7 files changed, 114 insertions(+), 10 deletions(-)

Range-diff against v1:
1:  a0ab068630 < -:  ---------- sparse-checkout: use string_list_sort_u
2:  b2c0ee2593 < -:  ---------- The 7th batch
3:  6af69c2c49 = 1:  1d544ef7d2 oidmap: make entry cleanup explicit in oidmap_clear
4:  452f5d8edb ! 2:  f2c3a699bd builtin/rev-list: migrate missing_objects cleanup to oidmap_clear_with_free()
    @@ Metadata
     Author: Seyi Kufoiji <[email-masked]>
     
      ## Commit message ##
    -    builtin/rev-list: migrate missing_objects cleanup to oidmap_clear_with_free()
    +    builtin/rev-list: migrate missing_objects cleanup to
    +    oidmap_clear_with_free()
     
         As part of the conversion away from oidmap_clear(), switch the
         missing_objects map to use oidmap_clear_with_free().
    @@ Commit message
     
         Introduce a dedicated free callback and pass it to
         oidmap_clear_with_free(), consolidating entry teardown into a
    -    single place and making cleanup semantics explicit. This improves
    -    clarity and maintainability.
    +    single place and making cleanup semantics explicit.
     
         Signed-off-by: Seyi Kuforiji <[email-masked]>
     
    @@ builtin/rev-list.c: static int arg_print_omitted; /* print objects omitted by fi
     +{
     +	struct missing_objects_map_entry *entry =
     +		container_of(e, struct missing_objects_map_entry, entry);
    ++
    ++	free(entry->path);
     +	free(entry);
     +}
     +
5:  cbfcc4e9cc = 3:  a4e426bcca list-objects-filter: use oidmap_clear_with_free() for cleanup
6:  bfbdb51d84 = 4:  4116e5491d odb: use oidmap_clear_with_free() to release replace_map entries
7:  4fc6e71f4c = 5:  ad1f776a19 sequencer: use oidmap_clear_with_free() for string_entry cleanup
-- 
2.43.0